[various] Payload updates, cleanup TODOs, coverage, documentation #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be able to have multiple types of signers for items, we need a TransactionSigner, to keep track of both the address, and the underlying crypto signer needed. It's most basic implementation is the Account
Additionally, fix the fungible asset client
Additionally fix some fungible asset calls
brianolson
approved these changes
Jun 6, 2024
| const testEd25519PublicKey = "0xde19e5d1880cac87d57484ce9ed2e84cf0f9599f12e7cc3a52e4e7657a763f2c" | ||
| const testEd25519Address = "0x978c213990c4833df71548df7ce49d54c759d6b6d932de22b24d56060b7af2aa" | ||
|
|
||
| // These come from fungible_asset.json |
There was a problem hiding this comment.
embed the json into the binary so that it can be read and parsed?
https://pkg.go.dev/embed
There was a problem hiding this comment.
This ideally would be built on a case by case basis, embedding in the binary could be interesting, but also less realistic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Plan
Related Links