[tests] Cleanup testsuite #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregnazario
force-pushed
the
cleanup-testsuite
branch
2 times, most recently
from
ec526ea
to
609ae27
Compare
brianolson
approved these changes
Jun 25, 2024
| @@ -15,11 +16,22 @@ const ( | |||
| vmStatusSuccess = "Executed successfully" | |||
| ) | |||
|
|
|||
| var TestSigners map[string]func() (TransactionSigner, error) | |||
| type CreateSigner func() (TransactionSigner, error) | |||
There was a problem hiding this comment.
my old Java senses are tingling and want to call this SignerFactory, not a big deal
There was a problem hiding this comment.
Oh boy factories.
Yeah, I'm going to quickly churn through cleanups on these, and we can look at that.
gregnazario
force-pushed
the
cleanup-testsuite
branch
from
609ae27
to
5524802
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleans up tests, adds some more coverage, fixes concurrent id passing
Test Plan
Related Links