rearrange concurrency in Test_Concurrent_Submission #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use different client for submission and N different clients for txn status waiting close channels when they're done simplify channel consuming syntax WaitGroup-s for intra-function goroutines
BuildTransactions, BuildSignAndSubmitTransactions, BuildSignAndSubmitTransactionsWithSignFunction get options Test_Concurrent_Submission ExpirationSeconds(20)
gregnazario
reviewed
Jun 25, 2024
Comment on lines
-382
to
+418
| client, err := NewClient(DevnetConfig) | ||
| client, err := NewClient(netConfig) |
There was a problem hiding this comment.
You should be able to use NewTestClient, which handles which network in one place (for this it's all localnet)
gregnazario
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use different client for submission and N different clients for txn status waiting close channels when they're done
simplify channel consuming syntax
WaitGroup-s for intra-function goroutines
Description
cleaner/stricter goroutine/chan usage
Test Plan
This is a test
Related Links