Documentation and some fixes along the way #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed and non-committed transactions
brianolson
reviewed
Jun 27, 2024
| assert.Empty(t, data.Transactions) | ||
| } | ||
|
|
||
| func TestBlockWithTransactions(t *testing.T) { |
There was a problem hiding this comment.
copy-paste-o? looks the same as 'with NO transactions'
There was a problem hiding this comment.
Yeah I think my PR got too big, and I just cut it off. Just have missed this
brianolson
reviewed
Jun 27, 2024
| @@ -1,3 +1,6 @@ | |||
| // Package types is an internal package that contains the types used in the Aptos Go SDK. | |||
There was a problem hiding this comment.
I think the convention is for this kind of note to go in doc.go (with no other code content)
There was a problem hiding this comment.
All the doc guides, don't give enough conventions, just worry about syntax. Will look into this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are some updates for a 0.6.0 release. Planning on finishing up documentation in another PR.
Breaking] Change type from Transaction to CommittedTransaction for cases that it's known they're committedFix] Fix some of the API types that didn't match on-chain representationsBreaking] Change ToAnyPublicKey to have an error in the outputTest Plan
See unit tests
Related Links