Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sdk to upstream branch lightmark/account_abstraction-update-aptos-protos #685

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 16 additions & 27 deletions rust/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions rust/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ sdk-processor = { path = "sdk-processor" }

ahash = { version = "0.8.7", features = ["serde"] }
anyhow = "1.0.86"
aptos-indexer-processor-sdk = { git = "https://github.com/aptos-labs/aptos-indexer-processor-sdk.git", rev = "a56b641a6aaca60092fcc9bbd98252f3cd703299" }
aptos-indexer-processor-sdk-server-framework = { git = "https://github.com/aptos-labs/aptos-indexer-processor-sdk.git", rev = "a56b641a6aaca60092fcc9bbd98252f3cd703299" }
aptos-protos = { git = "https://github.com/aptos-labs/aptos-core.git", rev = "6116af69aa173ca49e1761daabd6fe103fe2c65e" }
aptos-indexer-test-transactions = { git = "https://github.com/aptos-labs/aptos-core.git", rev = "ef80673093aa4df271ad33c2401421d642e7ff3c" }
aptos-indexer-testing-framework = { git = "https://github.com/aptos-labs/aptos-indexer-processor-sdk.git", rev = "a56b641a6aaca60092fcc9bbd98252f3cd703299" }
aptos-indexer-processor-sdk = { git = "https://github.com/aptos-labs/aptos-indexer-processor-sdk.git", rev = "b79ed8b5864b2a12a1f9c5fd01579462e029b2ae" }
aptos-indexer-processor-sdk-server-framework = { git = "https://github.com/aptos-labs/aptos-indexer-processor-sdk.git", rev = "b79ed8b5864b2a12a1f9c5fd01579462e029b2ae" }
aptos-protos = { git = "https://github.com/aptos-labs/aptos-core.git", rev = "1d8460a995503574ec4e9699d3442d0150d7f3b9" }
aptos-indexer-test-transactions = { git = "https://github.com/aptos-labs/aptos-core.git", rev = "1d8460a995503574ec4e9699d3442d0150d7f3b9" }
aptos-indexer-testing-framework = { git = "https://github.com/aptos-labs/aptos-indexer-processor-sdk.git", rev = "b79ed8b5864b2a12a1f9c5fd01579462e029b2ae" }
async-trait = "0.1.53"
backtrace = "0.3.58"
base64 = "0.13.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
SingleSender as SingleSenderPb,
};
use serde::{Deserialize, Serialize};
use tracing::warn;

#[derive(Clone, Debug, Deserialize, Serialize)]
pub struct Signature {
Expand Down Expand Up @@ -79,14 +80,28 @@
}
}

pub fn get_signature_type(t: &TransactionSignaturePb) -> String {
pub fn get_signature_type(t: &TransactionSignaturePb, transaction_version: i64) -> String {
if t.signature.is_none() {
warn!(

Check warning on line 85 in rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs

View check run for this annotation

Codecov / codecov/patch

rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs#L83-L85

Added lines #L83 - L85 were not covered by tests
transaction_version = transaction_version,
"Transaction signature is unknown"

Check warning on line 87 in rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs

View check run for this annotation

Codecov / codecov/patch

rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs#L87

Added line #L87 was not covered by tests
);
return String::from("unknown");
}

Check warning on line 90 in rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs

View check run for this annotation

Codecov / codecov/patch

rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs#L89-L90

Added lines #L89 - L90 were not covered by tests
match t.signature.as_ref().unwrap() {
SignatureEnum::Ed25519(_) => String::from("ed25519_signature"),
SignatureEnum::MultiEd25519(_) => String::from("multi_ed25519_signature"),
SignatureEnum::MultiAgent(_) => String::from("multi_agent_signature"),
SignatureEnum::FeePayer(_) => String::from("fee_payer_signature"),
SignatureEnum::SingleSender(sender) => {
let account_signature = sender.sender.as_ref().unwrap();
if account_signature.signature.is_none() {
warn!(

Check warning on line 99 in rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs

View check run for this annotation

Codecov / codecov/patch

rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs#L98-L99

Added lines #L98 - L99 were not covered by tests
transaction_version = transaction_version,
"Transaction signature is unknown"

Check warning on line 101 in rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs

View check run for this annotation

Codecov / codecov/patch

rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs#L101

Added line #L101 was not covered by tests
);
return String::from("unknown");
}

Check warning on line 104 in rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs

View check run for this annotation

Codecov / codecov/patch

rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs#L103-L104

Added lines #L103 - L104 were not covered by tests
let signature = account_signature.signature.as_ref().unwrap();
match signature {
AccountSignatureEnum::Ed25519(_) => String::from("ed25519_signature"),
Expand All @@ -99,6 +114,7 @@
AccountSignatureEnum::MultiKeySignature(_) => {
String::from("multi_key_signature")
},
AccountSignatureEnum::Abstraction(_) => String::from("abstraction_signature"),

Check warning on line 117 in rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs

View check run for this annotation

Codecov / codecov/patch

rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs#L117

Added line #L117 was not covered by tests
}
},
}
Expand Down Expand Up @@ -145,6 +161,29 @@
}
}

fn parse_abstraction_signature(
sender: &String,
transaction_version: i64,
transaction_block_height: i64,
is_sender_primary: bool,
multi_agent_index: i64,
override_address: Option<&String>,
) -> Self {
let signer = standardize_address(override_address.unwrap_or(sender));
Self {
txn_version: transaction_version,
transaction_block_height,
signer,
is_sender_primary,
type_: String::from("abstraction_signature"),
public_key: "Not implemented".into(),
threshold: 1,
signature: "Not implemented".into(),
multi_agent_index,
multi_sig_index: 0,
}
}

Check warning on line 185 in rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs

View check run for this annotation

Codecov / codecov/patch

rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs#L164-L185

Added lines #L164 - L185 were not covered by tests

fn parse_multi_ed25519_signature(
s: &MultiEd25519SignaturePb,
sender: &String,
Expand Down Expand Up @@ -263,6 +302,13 @@
multi_agent_index: i64,
override_address: Option<&String>,
) -> Vec<Self> {
if s.signature.is_none() {
warn!(

Check warning on line 306 in rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs

View check run for this annotation

Codecov / codecov/patch

rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs#L305-L306

Added lines #L305 - L306 were not covered by tests
transaction_version = transaction_version,
"Transaction signature is unknown"

Check warning on line 308 in rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs

View check run for this annotation

Codecov / codecov/patch

rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs#L308

Added line #L308 was not covered by tests
);
return vec![];
}

Check warning on line 311 in rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs

View check run for this annotation

Codecov / codecov/patch

rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs#L310-L311

Added lines #L310 - L311 were not covered by tests
let signature = s.signature.as_ref().unwrap();
match signature {
AccountSignatureEnum::Ed25519(sig) => vec![Self::parse_ed25519_signature(
Expand Down Expand Up @@ -303,6 +349,14 @@
multi_agent_index,
override_address,
),
AccountSignatureEnum::Abstraction(_sig) => vec![Self::parse_abstraction_signature(
sender,
transaction_version,
transaction_block_height,
is_sender_primary,
multi_agent_index,
override_address,
)],

Check warning on line 359 in rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs

View check run for this annotation

Codecov / codecov/patch

rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs#L352-L359

Added lines #L352 - L359 were not covered by tests
}
}

Expand Down Expand Up @@ -494,6 +548,13 @@
transaction_version: i64,
transaction_block_height: i64,
) -> Vec<Self> {
if s.sender.is_none() {
warn!(

Check warning on line 552 in rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs

View check run for this annotation

Codecov / codecov/patch

rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs#L551-L552

Added lines #L551 - L552 were not covered by tests
transaction_version = transaction_version,
"Transaction signature is unknown"

Check warning on line 554 in rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs

View check run for this annotation

Codecov / codecov/patch

rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs#L554

Added line #L554 was not covered by tests
);
return vec![];
}

Check warning on line 557 in rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs

View check run for this annotation

Codecov / codecov/patch

rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs#L556-L557

Added lines #L556 - L557 were not covered by tests
let signature = s.sender.as_ref().unwrap();
match signature.signature.as_ref() {
Some(AccountSignatureEnum::SingleKeySignature(s)) => {
Expand Down Expand Up @@ -534,6 +595,16 @@
0,
None,
),
Some(AccountSignatureEnum::Abstraction(_sig)) => {
vec![Self::parse_abstraction_signature(
sender,
transaction_version,
transaction_block_height,
true,
0,
None,
)]

Check warning on line 606 in rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs

View check run for this annotation

Codecov / codecov/patch

rust/processor/src/db/parquet/models/user_transaction_models/parquet_signatures.rs#L598-L606

Added lines #L598 - L606 were not covered by tests
},
None => vec![],
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
.unwrap()
.signature
.as_ref()
.map(Signature::get_signature_type)
.map(|s| Signature::get_signature_type(s, version))

Check warning on line 93 in rust/processor/src/db/parquet/models/user_transaction_models/parquet_user_transactions.rs

View check run for this annotation

Codecov / codecov/patch

rust/processor/src/db/parquet/models/user_transaction_models/parquet_user_transactions.rs#L93

Added line #L93 was not covered by tests
.unwrap_or_default(),
sender: standardize_address(&user_request.sender),
sequence_number: user_request.sequence_number as i64,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
account_signature::Signature as AccountSignature, signature::Signature, transaction::TxnData,
Transaction,
};
use tracing::warn;

trait AuthKeyScheme {
const SCHEME: u8;
Expand Down Expand Up @@ -253,7 +254,7 @@
}
}

fn from_transaction_signature(signature: &Signature) -> Option<Self> {
fn from_transaction_signature(signature: &Signature, transaction_version: i64) -> Option<Self> {
let info = match signature {
Signature::Ed25519(sig) => Self::ed25519(sig.public_key.clone()),
Signature::MultiEd25519(sigs) => {
Expand All @@ -265,7 +266,13 @@
},
Signature::SingleSender(single_sender) => {
let account_signature = single_sender.sender.as_ref().unwrap();

if account_signature.signature.is_none() {
warn!(

Check warning on line 270 in rust/processor/src/db/postgres/models/account_restoration_models/account_restoration_utils.rs

View check run for this annotation

Codecov / codecov/patch

rust/processor/src/db/postgres/models/account_restoration_models/account_restoration_utils.rs#L270

Added line #L270 was not covered by tests
transaction_version = transaction_version,
"Transaction signature is unknown"

Check warning on line 272 in rust/processor/src/db/postgres/models/account_restoration_models/account_restoration_utils.rs

View check run for this annotation

Codecov / codecov/patch

rust/processor/src/db/postgres/models/account_restoration_models/account_restoration_utils.rs#L272

Added line #L272 was not covered by tests
);
return None;

Check warning on line 274 in rust/processor/src/db/postgres/models/account_restoration_models/account_restoration_utils.rs

View check run for this annotation

Codecov / codecov/patch

rust/processor/src/db/postgres/models/account_restoration_models/account_restoration_utils.rs#L274

Added line #L274 was not covered by tests
}
let signature_info = match account_signature.signature.as_ref().unwrap() {
AccountSignature::Ed25519(sig) => Self::ed25519(sig.public_key.clone()),
AccountSignature::MultiEd25519(sigs) => {
Expand Down Expand Up @@ -301,6 +308,7 @@
.collect::<Vec<_>>();
Self::multi_key(threshold, prefixes, public_keys, verified)
},
AccountSignature::Abstraction(_sig) => return None,

Check warning on line 311 in rust/processor/src/db/postgres/models/account_restoration_models/account_restoration_utils.rs

View check run for this annotation

Codecov / codecov/patch

rust/processor/src/db/postgres/models/account_restoration_models/account_restoration_utils.rs#L311

Added line #L311 was not covered by tests
};
signature_info
},
Expand All @@ -322,6 +330,7 @@
TxnData::User(user_txn) => user_txn,
_ => return None,
};
let txn_version = txn.version as i64;
let address = user_txn.request.as_ref()?.sender.clone();
let signature_info = SignatureInfo::from_transaction_signature(
user_txn
Expand All @@ -331,9 +340,9 @@
.as_ref()?
.signature
.as_ref()?,
txn_version,
)?;
let auth_key = signature_info.auth_key().unwrap_or_default();
let txn_version = txn.version as i64;

let auth_key_account_address = AuthKeyAccountAddress {
auth_key: auth_key.clone(),
Expand Down
Loading
Loading