[FA migration] When coinstore is deleted we miss the FA activities #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #691 +/- ##
=======================================
- Coverage 49.6% 48.8% -0.8%
=======================================
Files 252 252
Lines 28660 28667 +7
=======================================
- Hits 14223 14002 -221
- Misses 14437 14665 +228 ☔ View full report in Codecov by Sentry. |
ying-w
reviewed
Jan 22, 2025
| // When coinstore is deleted we have no way of getting the mapping but hoping that there is | ||
| // only 1 coinstore deletion by owner address. This is a mapping between owner address and deleted coin type | ||
| // This is not ideal as we're assuming that there is only 1 coinstore deletion by owner address, this should be | ||
| // replaced by an event (although we still need to keep this mapping because blockchain) |
There was a problem hiding this comment.
CoinStoreDeletion will replace CoinEventHandleDeletion and include CoinStore aptos-labs/aptos-core#15730
There was a problem hiding this comment.
Great. I'm not using the events now so will just wait for that event to be on testnet and add the patch.
rtso
approved these changes
Jan 22, 2025
yuunlimm
force-pushed
the
fix_storage_id
branch
from
c07eeaf to
5dd1d06
Compare
bowenyang007
force-pushed
the
fix_coinstore_deletion
branch
from
0f6c2f8 to
e80845e
Compare
yuunlimm
approved these changes
Jan 22, 2025
bowenyang007
force-pushed
the
fix_coinstore_deletion
branch
from
948719b to
caebca5
Compare
bowenyang007
force-pushed
the
fix_coinstore_deletion
branch
from
caebca5 to
7c0a8fe
Compare
bowenyang007
force-pushed
the
fix_coinstore_deletion
branch
from
1cfaa42 to
9b483cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary solution until we have a better event that has both the event address and the coin type so that we can map withdraw / deposit events to the proper coin type.
Caveat, if there are multiple coinstore deletions in the same account, in the same transaction, we will get this wrong.
Backfill
When first v2 only apt was created.
Testnet: 2598047902
Mainnet: 1669115601
Testing
May need to add an integration test for this
Before we were missing apt withdraw
Now we have it!
