Skip to content

Commit

Permalink
added some circuit TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
alinush committed Feb 23, 2025
1 parent df51b1a commit 4405988
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,15 @@ git submodule update

## TODOs

### Prover service

- [ ] Why is the description of `keyless-common/` set to "Aptos Keyless circuit tests" in its `Cargo.toml`?
- [ ] The `Cargo.toml` description of `circuit/` also seem inappropriate
- [ ] Redundant `OnChainGroth16VerificationKey` struct
- [ ] Move some shared `prover` and `vk-diff` code to `keyless-common`

### Circuit

- [ ] Remove public inputs hash and do commit-and-prove
- [ ] Pedersen-based keyless addresses and avoid Poseidon hashing, except for Fiat-Shamir maybe

0 comments on commit 4405988

Please sign in to comment.