Slug will not be regenerated when owner object is updated #9
Conversation
| stale = true | ||
| end | ||
|
|
||
| if (permanent_slug? && (slug.nil? || slug.empty?)) || |
There was a problem hiding this comment.
IIRC, nil? || empty? is not an equivalent substitution for blank?. Don't we have blank? in the latest stable DM1? If IIRC, it comes from extlib or active_support.
There was a problem hiding this comment.
I think it's from active_support. I read somewhere that it's equivalent, but I can change it back to "blank?" for simplicity. If this is the only reason we need active_support, would there be benefit in keeping this line the way it is?
There was a problem hiding this comment.
No, I wouldn't introduce such a big dep just because of one method.
Though, blank? would be true for strings of spaces (like " "). On the other hand, empty? wouldn't. You most likely would like to have slug.strip.empty? here or something like that.
There was a problem hiding this comment.
Yep. Here's how ActiveSupport defines blank? for strings.
def blank?
self !~ /[^[:space:]]/
end
I encountered a scenario where updating my class would cause the slug to be regenerated. This became very painful when I had two identical slugs who were both being updated frequently, as each new slug would be generated with a bigger number-suffix ("slug-2" would become "slug-3" and so forth).
My fix is to change the circumstances in which a slug might be regenerated by altering the "#stale_slug?" method. I've added a spec test defining the bug I am trying to fix. "should not increment slug number when update doesn't affect slug generation." Using the old code for the #stale_slug? method, this test will fail.