Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Log Line Counter #34

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Adding Log Line Counter #34

merged 4 commits into from
Jul 9, 2024

Conversation

kitrady
Copy link
Contributor

@kitrady kitrady commented Jun 28, 2024

  • Added an analyzer that counts number of log lines
  • Added a test for this analyzer
  • Added this analyzer to the list of analyzers

benrady
benrady reviewed Jun 29, 2024
View reviewed changes
.idea/.gitignore Outdated Show resolved Hide resolved
benrady
benrady requested changes Jun 29, 2024
View reviewed changes
Copy link
Member

@benrady benrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor changes, but looks good overall!

@benrady benrady merged commit c777d12 into aquanauts:main Jul 9, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benrady benrady benrady approved these changes

@laurenassour laurenassour laurenassour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kitrady @benrady @laurenassour