Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding and debugging format analyzer #64

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Conversation

kitrady
Copy link
Contributor

@kitrady kitrady commented Jul 20, 2024

Closes #9

Added an analyzer that detects improperly formatted log lines and reports them. Also added a report messages to this and other analyzers I wrote because I realized I was just dumping the lines in the report with no explanation.

@benrady
Copy link
Member

benrady commented Jul 22, 2024

I can't resolve the merge conflicts in this PR through the web UI because Github is confusing the header lines with ======... for merge conflict lines. @kitrady you'll have to merge this with main and resolve the conflicts yourself before I can merge it

Copy link
Member

@benrady benrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to resolve merge conflicts

"resolving merge conflict"
@kitrady kitrady requested a review from benrady July 26, 2024 18:46
@benrady benrady enabled auto-merge (squash) July 26, 2024 20:03
@benrady benrady merged commit 60c614d into aquanauts:main Jul 26, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flag messages that do not conform to log line format
2 participants