Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance test for keyring #3176

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Performance test for keyring #3176

wants to merge 3 commits into from

Conversation

suzuki-shunsuke
Copy link
Member

@suzuki-shunsuke suzuki-shunsuke commented Oct 12, 2024

If aqua gets a GitHub Access Token from keyring, the performance makes worse.
So aqua exec should access kerying only when it is necessary.

$ hyperfine -N --warmup 3 '/Users/shunsukesuzuki/go/bin/aqua which mkghtag' '/Users/shunsukesuzuki/.local/share/aquaproj-aqua/bin/aqua which mkghtag'
Benchmark 1: /Users/shunsukesuzuki/go/bin/aqua which mkghtag
  Time (mean ± σ):      59.1 ms ±   3.3 ms    [User: 41.1 ms, System: 9.5 ms]
  Range (min … max):    55.0 ms …  68.6 ms    52 runs
 
Benchmark 2: /Users/shunsukesuzuki/.local/share/aquaproj-aqua/bin/aqua which mkghtag
  Time (mean ± σ):      32.9 ms ±   2.7 ms    [User: 33.0 ms, System: 3.6 ms]
  Range (min … max):    30.7 ms …  42.7 ms    92 runs
 
  Warning: Statistical outliers were detected. Consider re-running this benchmark on a quiet system without any interferences from other programs. It might help to use the '--warmup' or '--prepare' options.
 
Summary
  /Users/shunsukesuzuki/.local/share/aquaproj-aqua/bin/aqua which mkghtag ran
    1.80 ± 0.18 times faster than /Users/shunsukesuzuki/go/bin/aqua which mkghtag

@suzuki-shunsuke suzuki-shunsuke changed the title Feat keyring 2 Performance test for keyring Oct 12, 2024
@suzuki-shunsuke suzuki-shunsuke added enhancement New feature or request security labels Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant