This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Make types.h Object Ownership Story More Explicit #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 15, 2023 14:51
Replace with simpler delete_version as no caller actually cared about the previous version. Also removes the need for a transaction retry. Signed-off-by: Marcel Lauhoff <[email protected]>
Remove dead code
Signed-off-by: Marcel Lauhoff <[email protected]>
Object was a shared_ptr hidden behind 'ObjectRef' typedef. The shared ptr stems back from when there was a map of objects cache. Since we are no longer sharing Objects remove the shared_ptr and make the ownership of Object explicit. In most cases by using a unique_ptr. This also changes the behavior of refresh_meta when there is not (yet) a database record. We used to keep objref at nullptr. Now we initialize it with a default object that has deleted = true and set our state.exists to false. Signed-off-by: Marcel Lauhoff <[email protected]>
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object from types.h was still a shared pointer even though we moved
away from the std::map "cache" approach.
Make ownership more explicit and reduce scope of Object wherever
possible. Delete and refactor unused code on the way. Some code
because unsused due to the fact that many uses of Object are now
constant.
Checklist