This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
cmake: use nproc if _num_cores is zero
#259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jecluis
approved these changes
Nov 24, 2023
jecluis
added
kind/enhancement
Yeah, it's presently running on my 8 core desktop and seems to be actually using up to 6 of those cores at a time, rather than the previous 1. |
The previous workaround set _num_cores to 1 if cmake thought NUMBER_OF_LOGICAL_CORES was zero. That worked fine, but it'd be much better to take advantage of all possible cores. This version runs `nproc` which seems to work just fine under qemu-aarch64 and gives us the actual number of CPUs. Fixes: b666926 Signed-off-by: Tim Serong <[email protected]>
tserong
force-pushed
the
wip-better-workaround-qemu-zero-cpu-cores
branch
from
b204f06
to
d20b0f7
Compare
|
(oops, commit wasn't signed) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous workaround set _num_cores to 1 if cmake thought NUMBER_OF_LOGICAL_CORES was zero. That worked fine, but it'd be much better to take advantage of all possible cores. This version runs
nprocwhich seems to work just fine under qemu-aarch64 and gives us the actual number of CPUs.Fixes: b666926
Contribution Guidelines
Checklist