Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding eks-stig-kubernetes-v1r6 #1266

Merged
merged 5 commits into from
Sep 14, 2022

Conversation

crenzoaws
Copy link
Contributor

Closes #1247

@mozillazg
Copy link
Collaborator

@crenzoaws Thanks for your contribution! I'll review it when I have free time. Would you please update the document at https://github.com/aquasecurity/kube-bench/blob/main/docs/platforms.md to include this new benchmark?

@crenzoaws
Copy link
Contributor Author

@mozillazg

@mozillazg
Copy link
Collaborator

@crenzoaws Thanks for your update. I'll review it later.

Copy link
Collaborator

@mozillazg mozillazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Added some comments please check again, thanks!

cfg/eks-stig-kubernetes-v1r6/controlplane.yaml Outdated Show resolved Hide resolved
cfg/eks-stig-kubernetes-v1r6/controlplane.yaml Outdated Show resolved Hide resolved
cfg/eks-stig-kubernetes-v1r6/node.yaml Outdated Show resolved Hide resolved
cfg/eks-stig-kubernetes-v1r6/node.yaml Outdated Show resolved Hide resolved
cfg/eks-stig-kubernetes-v1r6/node.yaml Outdated Show resolved Hide resolved
cfg/eks-stig-kubernetes-v1r6/node.yaml Outdated Show resolved Hide resolved
cfg/eks-stig-kubernetes-v1r6/node.yaml Outdated Show resolved Hide resolved
cfg/eks-stig-kubernetes-v1r6/node.yaml Outdated Show resolved Hide resolved
hack/kind-stig.test.yaml Outdated Show resolved Hide resolved
@crenzoaws crenzoaws force-pushed the eks-stig-kubernetes-v1r6 branch from b4ce3da to ac2f311 Compare September 12, 2022 17:08
@crenzoaws
Copy link
Contributor Author

@mozillazg - Thanks for all your feedback. I've incorporated all the changes you've identified.

@crenzoaws
Copy link
Contributor Author

Upstream package error: sgerrand/alpine-pkg-glibc#185

@mozillazg
Copy link
Collaborator

@mozillazg - Thanks for all your feedback. I've incorporated all the changes you've identified.

Thanks for your patience. It looks like the integration/testdata/Expected_output_stig.data file needed to be updated too.

@crenzoaws crenzoaws force-pushed the eks-stig-kubernetes-v1r6 branch from b0c150e to 4e4aaad Compare September 14, 2022 14:05
Copy link
Collaborator

@mozillazg mozillazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution!

@chen-keinan chen-keinan merged commit a34047c into aquasecurity:main Sep 14, 2022
@crenzoaws crenzoaws deleted the eks-stig-kubernetes-v1r6 branch September 14, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DoD STIG Ver 1 Rel 6
3 participants