Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Age column to Report list pages #90

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@
"css-loader": "^5.0.0",
"mobx": "^6.3.0",
"mobx-react": "^7.2.0",
"moment": "^2.29.3",
"moment-timezone": "^0.5.34",
"sass": "^1.29.0",
"sass-loader": "^10.0.0",
"style-loader": "^2.0.0",
Expand Down
5 changes: 4 additions & 1 deletion src/ciskubebenchreports/page.scss
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,14 @@
flex-grow: 0.45;
}
&.summary {
flex-grow: 0.4;
flex-grow: 0.35;
}
&.scanner {
flex-grow: 0.15;
}
&.age {
flex-grow: 0.05;
}
}
}

Expand Down
16 changes: 15 additions & 1 deletion src/ciskubebenchreports/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {Renderer} from "@k8slens/extensions";
import React from "react";
import {store} from "./store";
import {CISKubeBenchReport} from "./types";
import formatDuration from "../utils/formatDuration";

const {
Component: {
Expand All @@ -14,6 +15,7 @@ const {
enum sortBy {
name = "name",
summary = "summary",
age = "age",
}

export class CISKubeBenchReportsPage extends React.Component<{ extension: Renderer.LensExtension }> {
Expand All @@ -30,7 +32,8 @@ export class CISKubeBenchReportsPage extends React.Component<{ extension: Render
report.report.summary.infoCount,
report.report.summary.passCount,
report.report.summary.warnCount,
]
],
[sortBy.age]: (report: CISKubeBenchReport) => report.metadata.creationTimestamp,
}}
searchFilters={[
(report: CISKubeBenchReport) => report.getSearchFields()
Expand All @@ -40,6 +43,7 @@ export class CISKubeBenchReportsPage extends React.Component<{ extension: Render
{title: "Name", className: "name", sortBy: sortBy.name},
{title: "Summary", className: "summary", sortBy: sortBy.summary},
{title: "Scanner", className: "scanner"},
{title: "Age", className: "age", sortBy: sortBy.age},
]}
renderTableContents={(report: CISKubeBenchReport) => [
report.getName(),
Expand All @@ -50,6 +54,7 @@ export class CISKubeBenchReportsPage extends React.Component<{ extension: Render
renderResult("pass", report.report.summary.passCount),
],
report.report.scanner.name + " " + report.report.scanner.version,
renderAge(report.metadata.creationTimestamp),
]}
/>
)
Expand All @@ -66,4 +71,13 @@ function renderResult(result: string, count: number) {
<Badge className="Badge" key="result" small label={count}/>
)
}
}

function renderAge(timestamp: string) {
const creationTimestamp = new Date(timestamp).getTime();
return (
<Badge flat expandable={false} key="age"
label={formatDuration(Date.now() - creationTimestamp, true)}
tooltip={timestamp} />
)
}
7 changes: 5 additions & 2 deletions src/configauditreports/page.scss
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,16 @@
flex-grow: 0.45;
}
&.namespace {
flex-grow: 0.1;
flex-grow: 0.075;
}
&.summary {
flex-grow: 0.3;
}
&.scanner {
flex-grow: 0.15;
flex-grow: 0.125;
}
&.age {
flex-grow: 0.05;
}
}
}
Expand Down
19 changes: 18 additions & 1 deletion src/configauditreports/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {Renderer} from "@k8slens/extensions";
import React from "react";
import {clusterStore, store} from "./store";
import {ClusterConfigAuditReport, ConfigAuditReport} from "./types";
import formatDuration from "../utils/formatDuration";

const {
Component: {
Expand All @@ -15,7 +16,8 @@ enum sortBy {
name = "name",
namespace = "namespace",
summary = "summary",
scanner = "scanner"
scanner = "scanner",
age = "age",
}

export class ClusterConfigAuditReportPage extends React.Component<{ extension: Renderer.LensExtension }> {
Expand All @@ -34,6 +36,7 @@ export class ClusterConfigAuditReportPage extends React.Component<{ extension: R
report.report.summary.lowCount
],
[sortBy.scanner]: (report: ClusterConfigAuditReport) => report.report.scanner.name + " " + report.report.scanner.version,
[sortBy.age]: (report: ConfigAuditReport) => report.metadata.creationTimestamp,
}}
searchFilters={[
(report: ClusterConfigAuditReport) => report.getSearchFields()
Expand All @@ -43,6 +46,7 @@ export class ClusterConfigAuditReportPage extends React.Component<{ extension: R
{title: "Name", sortBy: sortBy.name},
{title: "Summary", className: "summary", sortBy: sortBy.summary},
{title: "Scanner", sortBy: sortBy.scanner},
{title: "Age", className: "age", sortBy: sortBy.age},
]}
renderTableContents={(report: ClusterConfigAuditReport) => [
renderName(report.getName()),
Expand All @@ -53,6 +57,7 @@ export class ClusterConfigAuditReportPage extends React.Component<{ extension: R
renderSeverity("LOW", report.report.summary.lowCount),
],
report.report.scanner.name + " " + report.report.scanner.version,
renderAge(report.metadata.creationTimestamp),
]}
/>
)
Expand All @@ -76,6 +81,7 @@ export class ConfigAuditReportPage extends React.Component<{ extension: Renderer
report.report.summary.lowCount
],
[sortBy.scanner]: (report: ConfigAuditReport) => report.report.scanner.name + " " + report.report.scanner.version,
[sortBy.age]: (report: ConfigAuditReport) => report.metadata.creationTimestamp,
}}
searchFilters={[
(report: ConfigAuditReport) => report.getSearchFields()
Expand All @@ -86,6 +92,7 @@ export class ConfigAuditReportPage extends React.Component<{ extension: Renderer
{title: "Namespace", className: "namespace", sortBy: sortBy.namespace},
{title: "Summary", className: "summary", sortBy: sortBy.summary},
{title: "Scanner", className: "scanner", sortBy: sortBy.scanner},
{title: "Age", className: "age", sortBy: sortBy.age},
]}
renderTableContents={(report: ConfigAuditReport) => [
renderName(report.getName()),
Expand All @@ -97,6 +104,7 @@ export class ConfigAuditReportPage extends React.Component<{ extension: Renderer
renderSeverity("LOW", report.report.summary.lowCount),
],
report.report.scanner.name + " " + report.report.scanner.version,
renderAge(report.metadata.creationTimestamp),
]}
/>
)
Expand All @@ -119,4 +127,13 @@ function renderSeverity(severity: string, count: number) {
<Badge className="Badge" key="severity" small label={count}/>
)
}
}

function renderAge(timestamp: string) {
const creationTimestamp = new Date(timestamp).getTime();
return (
<Badge flat expandable={false} key="age"
label={formatDuration(Date.now() - creationTimestamp, true)}
tooltip={timestamp} />
)
}
91 changes: 91 additions & 0 deletions src/utils/formatDuration.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,91 @@
/**
* Copyright (c) OpenLens Authors. All rights reserved.
* Licensed under MIT License. See LICENSE in root directory for more information.
*/

import moment from "moment";

/**
* This function formats durations in a more human readable form.
* @param timeValue the duration in milliseconds to format
*/
export default function formatDuration(timeValue: number, compact = true) {
const duration = moment.duration(timeValue, "milliseconds");
const seconds = Math.floor(duration.asSeconds());
const separator = compact ? "": " ";

if (seconds < 0) {
return "0s";
} else if (seconds < 60*2 ) {
return `${seconds}s`;
}

const minutes = Math.floor(duration.asMinutes());

if (minutes < 10) {
const seconds = duration.seconds();

return getMeaningfulValues([minutes, seconds], ["m", "s"], separator);
} else if (minutes < 60 * 3) {
if (!compact) {
return getMeaningfulValues([minutes, duration.seconds()], ["m", "s"]);
}

return `${minutes}m`;
}

const hours = Math.floor(duration.asHours());

if(hours < 8) {
const minutes = duration.minutes();

return getMeaningfulValues([hours, minutes], ["h", "m"], separator);
} else if (hours < 48) {
if (compact) {
return `${hours}h`;
} else {
return getMeaningfulValues([hours, duration.minutes()], ["h", "m"]);
}
}

const days = Math.floor(duration.asDays());

if (days < 8) {
const hours = duration.hours();

if (compact) {
return getMeaningfulValues([days, hours], ["d", "h"], separator);
} else {
return getMeaningfulValues([days, hours, duration.minutes()], ["d", "h", "m"]);
}
}
const years = Math.floor(duration.asYears());

if (years < 2) {
if (compact) {
return `${days}d`;
} else {
return getMeaningfulValues([days, duration.hours(), duration.minutes()], ["d", "h", "m"]);
}
} else if (years < 8) {
const days = duration.days();

if (compact) {
return getMeaningfulValues([years, days], ["y", "d"], separator);
}
}

if (compact) {
return `${years}y`;
}

return getMeaningfulValues([years, duration.days(), duration.hours(), duration.minutes()], ["y", "d", "h", "m"]);
}

function getMeaningfulValues(values: number[], suffixes: string[], separator = " ") {
return values
.map((a, i): [number, string] => [a, suffixes[i]])
.filter(([dur]) => dur > 0)
.map(([dur, suf]) => dur + suf)
.join(separator);
}
7 changes: 5 additions & 2 deletions src/vulnerabilityreports/page.scss
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
flex-grow: 0.25;
}
&.namespace {
flex-grow: 0.1;
flex-grow: 0.075;
}
&.repository {
flex-grow: 0.25;
Expand All @@ -18,7 +18,10 @@
flex-grow: 0.3;
}
&.scanner {
flex-grow: 0.1;
flex-grow: 0.075;
}
&.age {
flex-grow: 0.05;
}
}
}
Expand Down
Loading