Live capture: fix corrupt state on Windows #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, Wireshark does not stop the capture program when using Wireshark's stop or restart button. If a capture is stopped that way and then restarted, the previous running capture prevents the new capture from being able to set up an SSH tunnel (for remote capture). To fix this we use a PID file and kill the previous capture before starting the new one. Additionally an already running Tracee container causes issues where the SSH tunnel forwarding thread gets a connection from Tracee before the reader thread starts which causes an error. To fix this we remove the existing Tracee container before we setup the new capture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, Wireshark does not stop the capture program when using Wireshark's stop or restart button. If a capture is stopped that way and then restarted, the previous running capture prevents the new capture from being able to set up an SSH tunnel (for remote capture). To fix this we use a PID file and kill the previous capture before starting the new one. Additionally an already running Tracee container causes issues where the SSH tunnel forwarding thread gets a connection from Tracee before the reader thread starts which causes an error. To fix this we remove the existing Tracee container before we setup the new capture.