Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(vulnsrc/nvd): define interfaces #464

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(vulnsrc/nvd): define interfaces #464

wants to merge 2 commits into from

Conversation

gshanbhag525
Copy link

@gshanbhag525 gshanbhag525 commented Nov 4, 2024 •
edited
Loading

  • interface metods are defined & exported to add additional logic fom Aqua Security side in "aqua-db" nvd tracker.

How has this been tested?

ran the test cases using make test and all of them passed.

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gshanbhag525 gshanbhag525 force-pushed the gun-add-interface-methods-to-nvd-tracker branch from 31de45d to f92c9dc Compare November 6, 2024 04:57
@gshanbhag525 gshanbhag525 marked this pull request as ready for review November 6, 2024 05:18
knqyf263
knqyf263 reviewed Nov 6, 2024
View reviewed changes
pkg/vulnsrc/nvd/nvd.go Outdated Show resolved Hide resolved
DmitriyLewen
DmitriyLewen approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263 knqyf263 enabled auto-merge (squash) November 6, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 left review comments

@DmitriyLewen DmitriyLewen DmitriyLewen approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gshanbhag525 @CLAassistant @knqyf263 @DmitriyLewen