refactor(read-through-data-cache): finalize caching before writing to DB

This is to ensure that temporary files are cleaned up before a
potentially blocking call to the DB.

src/data/read-through-data-cache.ts

@@ -190,6 +190,16 @@ export class ReadThroughDataCache implements ContiguousDataSource {
           if (cacheStream !== undefined) {
             const hash = hasher.digest('base64url');
 
+            try {
+              await this.dataStore.finalize(cacheStream, hash);
+            } catch (error: any) {
+              this.log.error('Error finalizing data in cache:', {
+                id,
+                message: error.message,
+                stack: error.stack,
+              });
+            }
+
             this.log.info('Successfully cached data', { id, hash });
             try {
               await this.contiguousDataIndex.saveDataContentAttributes({
@@ -207,16 +217,6 @@ export class ReadThroughDataCache implements ContiguousDataSource {
                 stack: error.stack,
               });
             }
-
-            try {
-              await this.dataStore.finalize(cacheStream, hash);
-            } catch (error: any) {
-              this.log.error('Error finalizing data in cache:', {
-                id,
-                message: error.message,
-                stack: error.stack,
-              });
-            }
           }
         }
       });