Skip to content

Commit

Permalink
build: skip GitHub action steps the require write perms on external PRs
Browse files Browse the repository at this point in the history
... so that checks can pass when people submit external PRs to the repo.
  • Loading branch information
djwhitt committed Aug 25, 2023
1 parent 44add3e commit b079be5
Showing 1 changed file with 13 additions and 9 deletions.
22 changes: 13 additions & 9 deletions .github/workflows/build-core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,36 +39,39 @@ jobs:
# Test results report
- name: Report test results
uses: dorny/test-reporter@v1
if: success() || failure()
if: >
(success() || failure()) &&
(github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
with:
name: Mocha tests
path: test-results.json
reporter: mocha-json

- name: Report code coverage
if: ${{ github.event_name == 'pull_request' }}
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
uses: romeovs/[email protected]
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
lcov-file: ./coverage/lcov.info

- name: Check code coverage threshold
uses: VeryGoodOpenSource/very_good_coverage@v2
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
with:
path: ./coverage/lcov.info
min_coverage: 50

# Build and push container image to GCR (only on main branch)
- name: Log in to the GitHub Container Registry
if: ${{ github.ref == 'refs/heads/main' }}
if: github.ref == 'refs/heads/main'
uses: docker/login-action@v1
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Build and push container image to GitHub Container Registry
if: ${{ github.ref == 'refs/heads/main' }}
if: github.ref == 'refs/heads/main'
uses: docker/build-push-action@v3
with:
push: true
Expand All @@ -78,17 +81,18 @@ jobs:
# Build and push container image to ECR
- name: Configure AWS credentials
if: github.event_name != 'pull_request'
uses: aws-actions/configure-aws-credentials@v2
with:
role-to-assume: arn:aws:iam::${{ secrets.AWS_ACCOUNT_ID }}:role/${{ secrets.AWS_BUILD_INVOCATION_ROLE }}
aws-region: ${{ secrets.AWS_REGION }}

- name: Login to ECR
if: ${{ github.ref == 'refs/heads/develop' }}
if: github.ref == 'refs/heads/develop'
uses: aws-actions/amazon-ecr-login@v1

- name: Push image ECR
if: ${{ github.ref == 'refs/heads/develop' }}
if: github.ref == 'refs/heads/develop'
uses: docker/build-push-action@v3
with:
labels: |
Expand All @@ -100,22 +104,22 @@ jobs:
# Start CodePipeline to test image
- name: Start CodePipeline
if: ${{ github.ref == 'refs/heads/develop' }}
if: github.ref == 'refs/heads/develop'
run: |
aws codepipeline start-pipeline-execution \
--name ${{ secrets.AWS_CODEPIPELINE_NAME }}
# Success notification
- name: Send Slack success notification
if: success()
if: success() && github.event_name != 'pull_request'
env:
SLACK_TITLE: Build succeeded!
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
uses: rtCamp/action-slack-notify@v2

# Failure notification
- name: Send Slack failure notification
if: failure()
if: failure() && github.event_name != 'pull_request'
env:
SLACK_TITLE: Build failed!
SLACK_COLOR: danger
Expand Down

0 comments on commit b079be5

Please sign in to comment.