fix(arns): return right away on arns HEAD requests

Avoid fetching data when handling HEAD requests for arns names
ar-io · Sep 12, 2024 · ccaf35f · ccaf35f
1 parent f765a76
commit ccaf35f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/src/constants.ts b/src/constants.ts
@@ -25,7 +25,7 @@ export const headerNames = {
   arnsResolvedId: 'X-ArNS-Resolved-Id',
   arnsProcessId: 'X-ArNS-Process-Id',
 };
-
+export const REQUEST_METHOD_HEAD = 'HEAD';
 export const DATA_PATH_REGEX =
   /^\/?([a-zA-Z0-9-_]{43})\/?$|^\/?([a-zA-Z0-9-_]{43})\/(.*)$/i;
 export const RAW_DATA_PATH_REGEX = /^\/raw\/([a-zA-Z0-9-_]{43})\/?$/i;

diff --git a/src/middleware/arns.ts b/src/middleware/arns.ts
@@ -19,7 +19,7 @@ import { Handler } from 'express';
 import { asyncMiddleware } from 'middleware-async';
 
 import * as config from '../config.js';
-import { headerNames } from '../constants.js';
+import { headerNames, REQUEST_METHOD_HEAD } from '../constants.js';
 import { sendNotFound } from '../routes/data/handlers.js';
 import { DATA_PATH_REGEX } from '../constants.js';
 import { NameResolution, NameResolver } from '../types.js';
@@ -105,5 +105,11 @@ export const createArnsMiddleware = ({
     res.header(headerNames.arnsProcessId, processId);
     // TODO: add a header for arns cache status
     res.header('Cache-Control', `public, max-age=${ttl}`);
+
+    if (req.method === REQUEST_METHOD_HEAD) {
+      res.end();
+      return;
+    }
+
     dataHandler(req, res, next);
   });
diff --git a/src/routes/data/handlers.ts b/src/routes/data/handlers.ts
@@ -20,7 +20,7 @@ import { default as asyncHandler } from 'express-async-handler';
 import { PassThrough, Transform } from 'node:stream';
 import rangeParser from 'range-parser';
 import { Logger } from 'winston';
-import { headerNames } from '../../constants.js';
+import { headerNames, REQUEST_METHOD_HEAD } from '../../constants.js';
 
 import { MANIFEST_CONTENT_TYPE } from '../../lib/encoding.js';
 import {
@@ -39,8 +39,6 @@ const NOT_FOUND_MAX_AGE = 60; // 1 minute
 
 const DEFAULT_CONTENT_TYPE = 'application/octet-stream';
 
-const REQUEST_METHOD_HEAD = 'HEAD';
-
 const setDataHeaders = ({
   res,
   dataAttributes,