-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docker): add ARNS_RESOLVER_OVERRIDE_TTL_SECONDS
to docker com…
#214
Conversation
…pose, default to undefined
📝 WalkthroughWalkthroughThe Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
docker-compose.yaml (1)
78-78
: LGTM! Consider adding a comment for clarity.The addition of the
ARNS_RESOLVER_OVERRIDE_TTL_SECONDS
environment variable is well-implemented and aligns with the PR objectives. It provides flexibility for configuring the ARNS resolver override TTL.Consider adding a brief comment above this line to explain the purpose and expected value range of this variable, which would enhance maintainability. For example:
# Override TTL (in seconds) for ARNS resolver. Leave empty for default behavior. - ARNS_RESOLVER_OVERRIDE_TTL_SECONDS=${ARNS_RESOLVER_OVERRIDE_TTL_SECONDS:-}
…pose, default to undefined