Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: root_parent_offset and X-AR-IO-Data-Item-Data-Offset header #228
feat: root_parent_offset and X-AR-IO-Data-Item-Data-Offset header #228
Changes from 1 commit
11812ae
6206e46
507bc89
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djwhitt do you think I should query DB to check if the calculation was done properly?
I don't think it make sense as this bundle will never change. One thing that I could do is to describe the reasoning like:
bdi has
root_parent_offset
X anddata_offset
Y so data item data offset should be Z.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karlprieb Let's skip checking against the DB but add a comparison of the data retrieved by requesting
Dc-q5iChuRWcsjVBFstEqmLTx4SWkGZxcVO9OTEGjkQ
by ID and using the size + root offset. That seems like a good sanity check since that's the functionality we're ultimately trying to enable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djwhitt here
507bc89
(#228)