Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(metrics): consolidate metric definitions into metrics.ts #39

Merged
merged 6 commits into from
Aug 30, 2023

Commits on Aug 29, 2023

  1. refactor(metrics): move global error metrics into metrics.ts PE-4401

    Each class managing its own metrics is nice in theory, but it makes it
    harder to see all the available metrics. It's also easy to get metric
    name collisions in tests since the metrics registry persists across test
    runs by default.
    djwhitt authored and dtfiedler committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    028fcbc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    54b175c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2f855b1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3c39c78 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d20e968 View commit details
    Browse the repository at this point in the history
  6. refactor(metrics): remove metrics registry from SQLLite and BlockImpo…

    …rter tests. PE-4401
    dtfiedler committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    0f21bc9 View commit details
    Browse the repository at this point in the history