docs: envs documentation #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…E-4552 When using a CDN we want to make sure that we do not use a long cache duration for endpoints like `/current_block` and `/height` where the response changes as each new block is produced. This change adds a Cache-Control max-age of 30 seconds for all proxied requests. In the future we will adjust this to be route specific (responses for block and TX by ID can be cached longer).
Bobinstein
reviewed
Sep 17, 2023
There was a problem hiding this comment.
you can add
LOG_FORMAT | string | "simple" | sets the format of output logs, accepts "simple" and "json"
INSTANCE_ID | string | "" | Adds an "instanceId" field to output logs
There was a problem hiding this comment.
I've added the missing ENVs.
Bobinstein
reviewed
Sep 17, 2023
There was a problem hiding this comment.
wrapping the values for ANS104_UNBUNDLE_FILTER and ANS104_INDEX_FILTER in single quotes can lead to parsing errors. The values do not need to be wrapped in any quotes.
There was a problem hiding this comment.
I've removed the single quotes.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should resolve the #47 issue.
I've noticed that the ENVs are quite well documented in the official docs. So I've just created a
.env.examplefile with all possible ENVs and their description.I've also created an
env.mdfile where all the ENVs are specified in the markdown table. It's up to you if you want to use the table in some different place in the docs.I've heard that @Bobinstein is working on docs, so his feedback will be more than appreciated.