Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Cabot to Python 3.6.5 and Django 3.2.5 #710

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

Ladrusca
Copy link

Hi, I migrated Cabot to python 3 and it works!
I also migrated the following plugins:
-cabot-check-http
-cabot-check-network
-cabot-alert-slack
-cabot-alert-email

@dbuxton
Copy link
Contributor

dbuxton commented Aug 20, 2021

I love it. Let me review

@dbuxton
Copy link
Contributor

dbuxton commented Aug 25, 2021

@Ladrusca @pablodgonzalez thanks for doing this. I'm going to carve out an hour to review this in the near future as I'd love to get merged. At the moment it's not super clear to me:

  • If there's major functionality that has been removed (e.g. REST API)
  • How to set up development
  • How to run tests
  • What modules work

Also if you can submit pull requests for the modules you've migrated that would be great.

@pablodgonzalez
Copy link
Contributor

Hi @dbuxton I am writing previusly to @Ladrusca do that

We have removed all plugins logic in cabot, and create an repo index with all plugins we have found in pypi/github here https://github.com/senzil/cabot-plugins

In that way cabot is thiner and more customizable to each use case.

For now we publish a pypi package named cabot3, forked all plugins and change the dependency from cabot to cabot3, no for a definitive setup but just temporal while the main cabot repo and pypi package are updated.

Right now we are working in the new Docker image and use github actions (because delete travis and docker hub has not more automated builds)

The plan is get the image working well and then add test steps in github actions. Of course, the tests about plugins does not have sense anymore. Maybe, is possible add some dummies check and alert to test the models and logic of cabot and growth the coverage?

Our idea is you can check all and to make progressive pull request to each plugin (some of course are unmaintained and I think they goes to keep in that way but the are in the index anyway)

@paulkitt
Copy link

Wow :)! Thanks for porting cabot to newer deps versions. Currently I have even trouble building the image.
Hope the MR goes through review :)

@bbarman4u
Copy link

@dbuxton @Ladrusca is there any chance this PR will go through ? I am also having difficulty understanding the building and using the steps to have an updated cabot image. I was trying to follow through from the forked repo, even though the cabot image builds but the application does not start up complaining about the missing plugins, so I am not sure how the plugins are supposed to be integrated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants