Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation warning #1570

Merged
merged 3 commits into from
Mar 21, 2020
Merged

Add deprecation warning #1570

merged 3 commits into from
Mar 21, 2020

Conversation

macor161
Copy link
Contributor

🦅 Pull Request Description

@macor161 macor161 requested a review from 0xGabi March 20, 2020 19:50
0xGabi
0xGabi approved these changes Mar 21, 2020
View reviewed changes
Copy link
Contributor

@0xGabi 0xGabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@0xGabi 0xGabi merged commit f86af68 into master Mar 21, 2020
@0xGabi 0xGabi deleted the deprecation-warning branch March 21, 2020 01:00
@sohkai
Copy link
Contributor

sohkai commented Mar 21, 2020 •
edited
Loading

I just saw that Running your app from a development HTTP server had quite a large heading, where it might be confusing since it's a subsection of aragon run.

Let's decrease it to a h4 or lower :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xGabi 0xGabi 0xGabi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macor161 @sohkai @0xGabi