Feat: Add overrides for apps without aragonPM repos (#114)

aragon · Jul 5, 2020 · 8011766 · 8011766
1 parent 84d8f02
commit 8011766
Show file tree

Hide file tree

Showing 17 changed files with 3,577 additions and 7 deletions.
diff --git a/packages/connect-core/src/entities/App.ts b/packages/connect-core/src/entities/App.ts
@@ -10,6 +10,11 @@ import {
 } from '../types'
 import { resolveMetadata } from '../utils/metadata'
 import { ConnectorInterface } from '../connections/ConnectorInterface'
+import {
+  getApmInternalAppInfo,
+  getAragonOsInternalAppInfo,
+} from '../utils/overrides/index'
+import { hasAppInfo } from '../utils/overrides/interfaces'
 
 // TODO:
 // [ ] (ipfs) contentUrl 	String 	The HTTP URL of the app content. Uses the IPFS HTTP provider. E.g. http://gateway.ipfs.io/ipfs/QmdLEDDfi…/ (ContentUri passing through the resolver)
@@ -73,11 +78,18 @@ export default class App extends CoreEntity {
     data: AppData,
     connector: ConnectorInterface
   ): Promise<App> {
-    const artifact: AragonArtifact = await resolveMetadata(
-      'artifact.json',
-      data.contentUri || undefined,
-      data.artifact
-    )
+    let artifact: AragonArtifact
+    if (hasAppInfo(data.appId, 'apm')) {
+      artifact = getApmInternalAppInfo(data.appId)
+    } else if (hasAppInfo(data.appId, 'aragon')) {
+      artifact = getAragonOsInternalAppInfo(data.appId)
+    } else {
+      artifact = await resolveMetadata(
+        'artifact.json',
+        data.contentUri || undefined,
+        data.artifact
+      )
+    }
 
     const manifest: AragonManifest = await resolveMetadata(
       'manifest.json',

diff --git a/packages/connect-core/src/utils/app.ts b/packages/connect-core/src/utils/app.ts
@@ -4,6 +4,9 @@ import { AppIntent } from '../types'
 import App from '../entities/App'
 import { TransactionRequestData } from '../transactions/TransactionRequest'
 
+export const apmAppId = (appName: string): string =>
+  ethers.utils.namehash(`${appName}.aragonpm.eth`)
+
 // Is the given method a full signature, e.g. 'foo(arg1,arg2,...)'
 export const isFullMethodSignature = (methodSignature: string): boolean => {
   return (