Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ODS to 1.0.20 #99

Merged
merged 9 commits into from
Apr 9, 2024
Merged

Update ODS to 1.0.20 #99

merged 9 commits into from
Apr 9, 2024

Conversation

xavikh
Copy link
Contributor

@xavikh xavikh commented Mar 26, 2024 •
edited
Loading

Also:

  • Updated most dependencies
  • Fixed an error in plugins/dualGovernance/hooks/useCanCreateProposal.tsx
  • Added console.error on createProposal errors

@xavikh xavikh changed the title Upgrade ODS to 1.0.20 Update ODS to 1.0.20 Mar 26, 2024
@xavikh xavikh requested review from carlosgj94 and brickpop March 27, 2024 09:21
brickpop
brickpop reviewed Mar 27, 2024
View reviewed changes
components/WalletContainer.tsx Show resolved Hide resolved
context/Web3Modal.tsx Show resolved Hide resolved
plugins/dualGovernance/hooks/useCanCreateProposal.tsx Outdated Show resolved Hide resolved
@xavikh xavikh requested a review from brickpop April 2, 2024 09:59
Fabricevladimir
Fabricevladimir reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@Fabricevladimir Fabricevladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Javier! Left a couple of comments/questions

plugins/dualGovernance/hooks/useCanCreateProposal.tsx Outdated Show resolved Hide resolved
plugins/dualGovernance/hooks/useCanCreateProposal.tsx Outdated Show resolved Hide resolved
plugins/dualGovernance/hooks/useCanCreateProposal.tsx Outdated Show resolved Hide resolved
plugins/dualGovernance/hooks/useCanCreateProposal.tsx
.catch((err) => {
console.error(err);
});
hasCreatePermissionRefetch();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about enabling/disabling query

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hook is to update the values in case the wallet address changes

@xavikh xavikh merged commit 01a4432 into main Apr 9, 2024
2 checks passed
@xavikh xavikh deleted the upgrade-ods branch April 9, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fabricevladimir Fabricevladimir Fabricevladimir left review comments

@brickpop brickpop brickpop approved these changes

@carlosgj94 carlosgj94 Awaiting requested review from carlosgj94

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xavikh @brickpop @Fabricevladimir