chore: Update naming of new prop

aragon · Sep 23, 2024 · 02ff986 · 02ff986
1 parent 7a1eca8
commit 02ff986
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,7 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ### Added
 
--   Add optional `voteLabel` prop to the `VoteProposalDataListItem` component in order to pass a custom string wen
+-   Add optional `confirmationLabel` prop to the `VoteProposalDataListItem` component in order to pass a custom string when
     needed.
 -   Add new `xs` size for core `Avatar` component
 

diff --git a/...aListItem/voteProposalDataListItemStructure/voteProposalDataListItemStructure.stories.tsx b/...aListItem/voteProposalDataListItemStructure/voteProposalDataListItemStructure.stories.tsx
@@ -35,7 +35,7 @@ export const TokenVotingCustomLabel: Story = {
         proposalTitle: 'Introduction of Layer 2 Scaling Solutions',
         voteIndicator: 'yes',
         date: 1613984914000,
-        voteLabel: 'Cutom label',
+        confirmationLabel: 'Cutom label',
     },
 };
 

diff --git a/...DataListItem/voteProposalDataListItemStructure/voteProposalDataListItemStructure.test.tsx b/...DataListItem/voteProposalDataListItemStructure/voteProposalDataListItemStructure.test.tsx
@@ -39,9 +39,9 @@ describe('<VoteProposalDataListItemStructure /> component', () => {
     });
 
     it('renders the custom label if available', () => {
-        const voteLabel = 'Custom label';
-        render(createTestComponent({ voteLabel }));
+        const confirmationLabel = 'Custom label';
+        render(createTestComponent({ confirmationLabel }));
 
-        expect(screen.getByText(voteLabel)).toBeInTheDocument();
+        expect(screen.getByText(confirmationLabel)).toBeInTheDocument();
     });
 });
diff --git a/...posalDataListItem/voteProposalDataListItemStructure/voteProposalDataListItemStructure.tsx b/...posalDataListItem/voteProposalDataListItemStructure/voteProposalDataListItemStructure.tsx
@@ -23,11 +23,11 @@ export type IVoteProposalDataListItemStructureProps = IDataListItemProps & {
     /**
      *   Custom label for the tag
      */
-    voteLabel?: string;
+    confirmationLabel?: string;
 };
 
 export const VoteProposalDataListItemStructure: React.FC<IVoteProposalDataListItemStructureProps> = (props) => {
-    const { proposalTitle, proposalId, voteIndicator, date, voteLabel, className, ...otherProps } = props;
+    const { proposalTitle, proposalId, voteIndicator, date, confirmationLabel, className, ...otherProps } = props;
 
     const { copy } = useOdsModulesContext();
 
@@ -41,7 +41,7 @@ export const VoteProposalDataListItemStructure: React.FC<IVoteProposalDataListIt
                 <span className="truncate text-neutral-800">{proposalTitle}</span>
             </div>
             <div className="flex items-center gap-x-1 text-sm font-normal leading-tight text-neutral-500 md:gap-x-1.5 md:text-base">
-                <span>{voteLabel ?? copy.voteProposalDataListItemStructure.voted}</span>
+                <span>{confirmationLabel ?? copy.voteProposalDataListItemStructure.voted}</span>
                 <Tag
                     variant={voteIndicatorToTagVariant[voteIndicator]}
                     className="capitalize"