Changed VoterListItem onClick action to open etherscan (#21)

aragon · Aug 23, 2023 · 8636dee · 8636dee
1 parent 45f2c11
commit 8636dee
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+-   `VoterListItem` onClick action to open etherscan
+
 ## [0.2.11] - 2023-08-23
 
 ### Fixed

diff --git a/src/components/listItem/voter.tsx b/src/components/listItem/voter.tsx
@@ -28,7 +28,7 @@ export type ListItemVoterProps = ButtonHTMLAttributes<HTMLButtonElement> & {
     walletTag?: TagProps;
     voteReplaced?: boolean;
     voteReplacedLabel?: string;
-    onClick: () => null;
+    onClick: () => void;
 };
 
 const colorScheme = (option: string) =>

diff --git a/src/components/table/votersTable.stories.tsx b/src/components/table/votersTable.stories.tsx
@@ -41,4 +41,5 @@ Default.args = {
     onLoadMore: () => alert('load more clicked'),
     showOption: true,
     showAmount: true,
+    explorerURL: 'https://etherscan.io/',
 };
diff --git a/src/components/table/votersTable.tsx b/src/components/table/votersTable.tsx
@@ -24,6 +24,7 @@ export type VotersTableProps = {
     showOption?: boolean;
     showAmount?: boolean;
     pageSize?: number; // number of rows to show
+    explorerURL: string;
 };
 
 const colorScheme = (option: VoterType['walletTag']) => (option === 'You' ? 'neutral' : 'info');
@@ -35,6 +36,7 @@ export const VotersTable: React.FC<VotersTableProps> = ({
     page = 1,
     showAmount = false,
     pageSize = 3,
+    explorerURL,
 }) => {
     const displayedVoters = page * pageSize;
 
@@ -46,7 +48,9 @@ export const VotersTable: React.FC<VotersTableProps> = ({
                     label={shortenAddress(voter.wallet)}
                     src={voter.src}
                     option={voter.option}
-                    onClick={() => null}
+                    onClick={() => {
+                        window.open(`${explorerURL}address/${voter.wallet}`, '_blank');
+                    }}
                     voteReplaced={voter.voteReplaced}
                     {...(voter.walletTag && {
                         walletTag: {