Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APP-2761 - Introduce z-index component customisations for the Dropdown and Dialogs components #124

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

cgero-eth
Copy link
Contributor

@cgero-eth cgero-eth commented Mar 13, 2024

Description

  • Introduce component customisations for the z-index property of the Dropdown and Dialogs components

Task: APP-2761

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

Copy link
Contributor

@Fabricevladimir Fabricevladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cgero-eth. Good to go. Why opt for per component files as opposed to a singular z-index pseudo-token dedicated CSS file? I get the separation of concerns, but it makes it quite a bit harder to chase down all the individual custom variables, on the other had, works great for when you're trying to determine whether a particular component has customizable z-index.

@cgero-eth
Copy link
Contributor Author

Thanks @cgero-eth. Good to go. Why opt for per component files as opposed to a singular z-index pseudo-token dedicated CSS file? I get the separation of concerns, but it makes it quite a bit harder to chase down all the individual custom variables, on the other had, works great for when you're trying to determine whether a particular component has customizable z-index.

Good point, I thought that in the future we might have multiple customisations per component, we might make colors, background, texts customisable for each component. In that way we'll have all the customisations for one component in a single file, even though it looks pretty scattered right now as we only have z-index customisations

@cgero-eth cgero-eth merged commit 5760913 into main Mar 13, 2024
3 checks passed
@cgero-eth cgero-eth deleted the make-z-index-customisable branch March 13, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants