Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APP-2988 - Implement StatePingAnimation core component #126

Merged

Conversation

Fabricevladimir
Copy link
Contributor

@Fabricevladimir Fabricevladimir commented Mar 13, 2024

Description

  • Implements the StatePingAnimation core component

Task: APP-2988

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

@Fabricevladimir Fabricevladimir requested a review from a team March 13, 2024 12:47
Copy link
Contributor

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Fabricevladimir! Could you just update the .storybook/preview.tsx file and fix the OdsModulesProvider import to:

import { OdsModulesProvider } from '../src/modules';

I introduced the issue on the storybook stories when removing the modules export :/

@Fabricevladimir Fabricevladimir merged commit 48deac0 into main Mar 13, 2024
4 checks passed
@Fabricevladimir Fabricevladimir deleted the feat-APP-2988-implement-state-ping-animation-component branch March 13, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants