Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: APP-2795 - Implement AssetDataListItemStructure module component #128

Merged
merged 30 commits into from
Mar 27, 2024
Merged

feat: APP-2795 - Implement AssetDataListItemStructure module component #128

merged 30 commits into from
Mar 27, 2024

Conversation

sepehr2github
Copy link
Contributor

@sepehr2github sepehr2github commented Mar 15, 2024 •
edited by jira bot
Loading

Description

  • Implement AssetDataListItemStructure module component

Task: APP-2795

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

sepehr2github and others added 22 commits March 11, 2024 22:53
@sepehr2github
feat: implment DaoDataListItem
24c64b8
@sepehr2github
tests added
cc66327
@sepehr2github
add responsive support
b2205c0
@sepehr2github
fix: final cleanup
7fc474d
@sepehr2github
chore: update CHANGELOG.MD
fbddc6a
@sepehr2github @cgero-eth
Update CHANGELOG.md
45d5073 
Co-authored-by: cgero.eth <[email protected]>
@sepehr2github @cgero-eth
Update src/modules/components/dao/daoDataListItem/index.ts
5006ac3 
Co-authored-by: cgero.eth <[email protected]>
@sepehr2github @cgero-eth
Update src/modules/components/dao/daoDataListItem/daoDataListItem.tsx
55b0102 
Co-authored-by: cgero.eth <[email protected]>
@sepehr2github
fix: resolve comment
aafac5e
@sepehr2github
Merge branch 'f/app-2789' of https://github.com/aragon/ods into f/app…
5c9e782 
…-2789
@sepehr2github
fix: update file names
ebf3330
@sepehr2github
resolve comments
0b92344
@sepehr2github
Merge branch 'main' into f/app-2789
eddc477
@sepehr2github
fix: update classes
783084b
@sepehr2github @cgero-eth
Update CHANGELOG.md
704482d 
Co-authored-by: cgero.eth <[email protected]>
@sepehr2github @cgero-eth
Update src/modules/components/dao/daoDataListItem/daoDataListItemStru…
af7c4fb 
…cture/daoDataListItemStructure.tsx

Co-authored-by: cgero.eth <[email protected]>
@sepehr2github
fix: update padding based on figma sizes
5267ae7
@sepehr2github
Merge branch 'main' into f/app-2789
40a84d7
@sepehr2github
update changelog
95ef87d
@sepehr2github
Merge branch 'main' into f/app-2789
04a5a5a
@sepehr2github
feature: added AssetDataListItem.Structure
3b469f8
@sepehr2github
chore: Merge branch 'main' into f/app-2795
e7ee172
@sepehr2github sepehr2github requested a review from a team March 15, 2024 07:38
@cgero-eth cgero-eth self-assigned this Mar 25, 2024
cgero-eth
cgero-eth reviewed Mar 25, 2024
View reviewed changes
Copy link
Contributor

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the implementation @sepehr2github!

src/modules/components/asset/assetDataListItem/assetDataListItemStructure/index.ts Outdated Show resolved Hide resolved
...components/asset/assetDataListItem/assetDataListItemStructure/assetDataListItemStructure.tsx Outdated Show resolved Hide resolved
...components/asset/assetDataListItem/assetDataListItemStructure/assetDataListItemStructure.tsx Outdated Show resolved Hide resolved
...components/asset/assetDataListItem/assetDataListItemStructure/assetDataListItemStructure.tsx Outdated Show resolved Hide resolved
...components/asset/assetDataListItem/assetDataListItemStructure/assetDataListItemStructure.tsx Outdated Show resolved Hide resolved
...components/asset/assetDataListItem/assetDataListItemStructure/assetDataListItemStructure.tsx Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
...ts/asset/assetDataListItem/assetDataListItemStructure/assetDataListItemStructure.stories.tsx Outdated Show resolved Hide resolved
...nents/asset/assetDataListItem/assetDataListItemStructure/assetDataListItemStructure.test.tsx Outdated Show resolved Hide resolved
...nents/asset/assetDataListItem/assetDataListItemStructure/assetDataListItemStructure.test.tsx Outdated Show resolved Hide resolved
Fabricevladimir
Fabricevladimir reviewed Mar 25, 2024
View reviewed changes
Copy link
Contributor

@Fabricevladimir Fabricevladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sepehr! Left a couple comments

CHANGELOG.md Outdated Show resolved Hide resolved
src/modules/components/asset/index.ts Show resolved Hide resolved
src/modules/components/asset/assetDataListItem/assetDataListItemStructure/index.ts Outdated Show resolved Hide resolved
...ts/asset/assetDataListItem/assetDataListItemStructure/assetDataListItemStructure.stories.tsx Outdated Show resolved Hide resolved
...components/asset/assetDataListItem/assetDataListItemStructure/assetDataListItemStructure.tsx Outdated Show resolved Hide resolved
...components/asset/assetDataListItem/assetDataListItemStructure/assetDataListItemStructure.tsx Outdated Show resolved Hide resolved
...components/asset/assetDataListItem/assetDataListItemStructure/assetDataListItemStructure.tsx Outdated Show resolved Hide resolved
...components/asset/assetDataListItem/assetDataListItemStructure/assetDataListItemStructure.tsx Outdated Show resolved Hide resolved
...components/asset/assetDataListItem/assetDataListItemStructure/assetDataListItemStructure.tsx Show resolved Hide resolved
...components/asset/assetDataListItem/assetDataListItemStructure/assetDataListItemStructure.tsx Outdated Show resolved Hide resolved
cgero-eth
cgero-eth reviewed Mar 26, 2024
View reviewed changes
...components/asset/assetDataListItem/assetDataListItemStructure/assetDataListItemStructure.tsx Outdated Show resolved Hide resolved
...components/asset/assetDataListItem/assetDataListItemStructure/assetDataListItemStructure.tsx Show resolved Hide resolved
...components/asset/assetDataListItem/assetDataListItemStructure/assetDataListItemStructure.tsx Outdated Show resolved Hide resolved
...nents/asset/assetDataListItem/assetDataListItemStructure/assetDataListItemStructure.test.tsx Outdated Show resolved Hide resolved
...nents/asset/assetDataListItem/assetDataListItemStructure/assetDataListItemStructure.test.tsx Outdated Show resolved Hide resolved
...components/asset/assetDataListItem/assetDataListItemStructure/assetDataListItemStructure.tsx Outdated Show resolved Hide resolved
@Fabricevladimir Fabricevladimir changed the title feat: APP-2727 - Implement AssetDataListItemStructure module component feat: APP-2795 - Implement AssetDataListItemStructure module component Mar 26, 2024
cgero-eth
cgero-eth approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me, thanks @sepehr2github! 🙌🏻

@cgero-eth cgero-eth merged commit a7cceee into main Mar 27, 2024
4 checks passed
@cgero-eth cgero-eth deleted the f/app-2795 branch March 27, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgero-eth cgero-eth cgero-eth approved these changes

@Fabricevladimir Fabricevladimir Awaiting requested review from Fabricevladimir

Assignees

@cgero-eth cgero-eth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sepehr2github @Fabricevladimir @cgero-eth