Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: APP-2797 - Implement TransactionDataListItem.Structure module component #130

Closed
wants to merge 23 commits into from
Closed

feat: APP-2797 - Implement TransactionDataListItem.Structure module component #130

wants to merge 23 commits into from

Conversation

thekidnamedkd
Copy link
Contributor

@thekidnamedkd thekidnamedkd commented Mar 25, 2024 •
edited
Loading

Description

Implement TransactionDataListItemStructure component + timestamp formatter & block explorer link creation utilities

Task: APP-2797

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.

@thekidnamedkd thekidnamedkd requested a review from a team March 25, 2024 10:55
@Fabricevladimir Fabricevladimir self-assigned this Mar 26, 2024
@Fabricevladimir Fabricevladimir requested review from Fabricevladimir and removed request for a team March 26, 2024 16:53
Fabricevladimir
Fabricevladimir reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@Fabricevladimir Fabricevladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Kevin! Left a few comments and questsions

CHANGELOG.md Outdated Show resolved Hide resolved
src/modules/utils/timestampUtils/timestampUtils.ts Outdated Show resolved Hide resolved
src/modules/utils/blockExplorerUtils/blockExplorerUtils.ts Outdated Show resolved Hide resolved
...les/components/transaction/transactionDataListItem/transactionDataListItemStructure/index.ts Outdated Show resolved Hide resolved
...sactionDataListItem/transactionDataListItemStructure/transactionDataListItemStructure.api.ts Outdated Show resolved Hide resolved
...onDataListItem/transactionDataListItemStructure/transactionDataListItemStructure.stories.tsx Show resolved Hide resolved
...sactionDataListItem/transactionDataListItemStructure/transactionDataListItemStructure.api.ts Outdated Show resolved Hide resolved
...sactionDataListItem/transactionDataListItemStructure/transactionDataListItemStructure.api.ts Outdated Show resolved Hide resolved
...on/transactionDataListItem/transactionDataListItemStructure/transactionDataListItem.test.tsx Outdated Show resolved Hide resolved
...on/transactionDataListItem/transactionDataListItemStructure/transactionDataListItem.test.tsx Outdated Show resolved Hide resolved
cgero-eth
cgero-eth reviewed Apr 3, 2024
View reviewed changes
...on/transactionDataListItem/transactionDataListItemStructure/transactionDataListItem.test.tsx Show resolved Hide resolved
...on/transactionDataListItem/transactionDataListItemStructure/transactionDataListItem.test.tsx Outdated Show resolved Hide resolved
...on/transactionDataListItem/transactionDataListItemStructure/transactionDataListItem.test.tsx Outdated Show resolved Hide resolved
...ransactionDataListItem/transactionDataListItemStructure/transactionDataListItemStructure.tsx Outdated Show resolved Hide resolved
...ransactionDataListItem/transactionDataListItemStructure/transactionDataListItemStructure.tsx Outdated Show resolved Hide resolved
...ransactionDataListItem/transactionDataListItemStructure/transactionDataListItemStructure.tsx Outdated Show resolved Hide resolved
...ransactionDataListItem/transactionDataListItemStructure/transactionDataListItemStructure.tsx Outdated Show resolved Hide resolved
...sactionDataListItem/transactionDataListItemStructure/transactionDataListItemStructure.api.ts Outdated Show resolved Hide resolved
...sactionDataListItem/transactionDataListItemStructure/transactionDataListItemStructure.api.ts Outdated Show resolved Hide resolved
...sactionDataListItem/transactionDataListItemStructure/transactionDataListItemStructure.api.ts Outdated Show resolved Hide resolved
@thekidnamedkd thekidnamedkd changed the title feat: APP-2797 - Implement TransactionDataListItemStructure feat: APP-2797 - Implement TransactionDataListItem.Structure module component Apr 3, 2024
cgero-eth
cgero-eth approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @thekidnamedkd! ✅

@cgero-eth cgero-eth deleted the feat/APP-2797 branch July 23, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanaronson evanaronson evanaronson left review comments

@cgero-eth cgero-eth cgero-eth approved these changes

@Fabricevladimir Fabricevladimir Awaiting requested review from Fabricevladimir

Assignees

@Fabricevladimir Fabricevladimir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thekidnamedkd @Fabricevladimir @cgero-eth @evanaronson