Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update formatter to handle negative numbers and withSign option #131

Merged
merged 8 commits into from
Mar 27, 2024

Conversation

cgero-eth
Copy link
Contributor

Description

  • Update formatter to handle withSign option
  • Allow every format to be customised

TODO:

  • Waiting okay from product

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

Copy link

github-actions bot commented Mar 25, 2024

Storybook IPFS Hash: QmV9gfCMnRDDpyMvawXQZVbhQDYnaTbNMVPT8dyfwSgXPB
ODS deployed to https://ipfs.eth.aragon.network/ipfs/QmV9gfCMnRDDpyMvawXQZVbhQDYnaTbNMVPT8dyfwSgXPB/

@cgero-eth cgero-eth added preview and removed preview labels Mar 25, 2024
@cgero-eth cgero-eth changed the title feat: Update formatter to handle withSign options feat: Update formatter to handle negative numbers and withSign option Mar 26, 2024
@cgero-eth cgero-eth marked this pull request as ready for review March 26, 2024 15:37
@cgero-eth cgero-eth requested a review from a team March 26, 2024 15:37
@cgero-eth cgero-eth force-pushed the handle-sign-param-on-formatter branch from 38be263 to 93cdf91 Compare March 27, 2024 09:36
Copy link
Contributor

@Fabricevladimir Fabricevladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍🏾

@cgero-eth cgero-eth merged commit 1af7dba into main Mar 27, 2024
4 checks passed
@cgero-eth cgero-eth deleted the handle-sign-param-on-formatter branch March 27, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants