Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: VoterListItem component #20

Merged
merged 8 commits into from
Aug 23, 2023
Merged

Feature: VoterListItem component #20

merged 8 commits into from
Aug 23, 2023

Conversation

sepehr2github
Copy link
Contributor

@sepehr2github sepehr2github commented Aug 21, 2023

Description

  • VoterListItem component added
  • Refactored VotersTable component according to new ODS designs

Task: APP-2368

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

Copy link
Contributor

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from some small adjustments on the changelog file the PR looks good, thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
@sepehr2github sepehr2github merged commit 15f7dcf into main Aug 23, 2023
4 checks passed
@sepehr2github sepehr2github deleted the f/app-2368 branch August 23, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants