Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APP-2446 - Improve customisation of TextInput component, fix issues on WalletInput component #26

Merged
merged 6 commits into from
Sep 19, 2023

Conversation

cgero-eth
Copy link
Contributor

@cgero-eth cgero-eth commented Sep 15, 2023

Description

  • Add containerClassName property to TextInput component to add classes to the component's wrapper
  • Fix racing conditions when resolving ENS or addresses on WalletInput component. This is happening on the delegation flow on this usecase:
1. Component is mounted with address that has an ENS domain, the component tries to resolve the ENS
2. The value is changed to a value without ENS name, ENS resolving starts and ends immediately
3. The ENS name of the initial value is resolved and the value is updated to the initial value
  • Correctly update the display mode of the WalletInput component when changing the component's value programmatically. Currently we are updating the display mode only when changing the value through the input field

Task: APP-2446

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

@cgero-eth cgero-eth requested a review from a team September 15, 2023 09:55
Copy link
Contributor

@sepehr2github sepehr2github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, One minor comment left!

@cgero-eth cgero-eth merged commit 9dffb32 into main Sep 19, 2023
5 checks passed
@cgero-eth cgero-eth deleted the fix-APP-2446-fix-components branch September 19, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants