-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(APP-3614): Support dropdown-item actions on ProposalActions, update DataListItem to support standalone usage #294
Conversation
…ist item components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I saw 64 files change and my eyes popped, but I see it's a lot of pattern adjustment and storybook cleanup. Thanks for the implementation! Left a few Q's as always. :)
...les/components/proposal/proposalActions/proposalActionsAction/proposalActionsAction.test.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! TAction makes sense. I was thinking about that when doing the ProposalActions about how to make it more general and flexible as actions could be anything down the road.
Description
dropdownItems
property on ProposalActions to display custom actionsDataListItem
component to support button/link rendering and standalone usageDropdownItem
style to correctly render items with icons aligned on the left🟥 The only breaking change of this PR would be that if some app component is extending a data-list-item property interface (
IDataListItemProps
,IVoteDataListItemProps
, ..), the related props need to be changed frominterface
totype
Task: APP-3614
Type of change
Checklist:
CHANGELOG.md
file in the root folder of the package after the [UPCOMING] title and beforethe latest version.