Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update DefinitionListItem and Breadcrumbs components to truncate long strings #316

Merged
merged 3 commits into from
Oct 23, 2024
Merged

fix: Update DefinitionListItem and Breadcrumbs components to truncate long strings #316

merged 3 commits into from
Oct 23, 2024

Conversation

cgero-eth
Copy link
Contributor

@cgero-eth cgero-eth commented Oct 23, 2024 •
edited
Loading

Description

  • Update DefinitionListItem and Breadcrumbs components to truncate long strings

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

@cgero-eth cgero-eth requested a review from a team October 23, 2024 09:13
@cgero-eth cgero-eth changed the title fix: Update DefinitionListItem style to support truncation of long definitions fix: Update DefinitionListItem and Breadcrumbs components to truncate long strings Oct 23, 2024
shan8851
shan8851 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@shan8851 shan8851 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgero-eth cgero-eth merged commit 43ff9b3 into main Oct 23, 2024
4 checks passed
@cgero-eth cgero-eth deleted the definition-list-truncate branch October 23, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shan8851 shan8851 shan8851 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgero-eth @shan8851