Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix InputNumber component to trigger onChange callback on + / - button click #317

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix: Fix InputNumber component to trigger onChange callback on + / - button click #317

merged 1 commit into from
Oct 23, 2024

Conversation

cgero-eth
Copy link
Contributor

Description

  • Fix InputNumber component, update tests and stories

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

@cgero-eth cgero-eth requested a review from a team October 23, 2024 10:00
@cgero-eth cgero-eth changed the title fix: Fix input-number component to trigger onChange callback on + / - button click fix: Fix InputNumber component to trigger onChange callback on + / - button click Oct 23, 2024
shan8851
shan8851 previously approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@shan8851 shan8851 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgero-eth cgero-eth force-pushed the fix-input-number-to-trigger-onchange branch from c9ea9f5 to 31ac62a Compare October 23, 2024 12:07
@cgero-eth cgero-eth merged commit 6856a5d into main Oct 23, 2024
4 checks passed
@cgero-eth cgero-eth deleted the fix-input-number-to-trigger-onchange branch October 23, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shan8851 shan8851 shan8851 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgero-eth @shan8851