Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add holesky support configuration #92

Merged
merged 3 commits into from
Jul 2, 2024
Merged

chore: Add holesky support configuration #92

merged 3 commits into from
Jul 2, 2024

Conversation

Rekard0
Copy link
Contributor

@Rekard0 Rekard0 commented Jul 1, 2024 •
edited
Loading

Description

Add holesky support configuration

Task ID: OS-1411

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I created tasks to update dependent repositories (OSx, Plugins)
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.

clauBv23
clauBv23 approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@clauBv23 clauBv23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Rekard0 Rekard0 merged commit 39a9632 into develop Jul 2, 2024
5 checks passed
@Rekard0 Rekard0 deleted the feature/add-holesky-support branch July 2, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clauBv23 clauBv23 clauBv23 approved these changes

@novaknole novaknole Awaiting requested review from novaknole

Assignees
No one assigned
Labels
configs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rekard0 @clauBv23