Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new dev sepolia network deployment #96

Merged
merged 4 commits into from
Aug 7, 2024
Merged

feat: new dev sepolia network deployment #96

merged 4 commits into from
Aug 7, 2024

Conversation

clauBv23
Copy link
Contributor

@clauBv23 clauBv23 commented Aug 5, 2024 •
edited by jira bot
Loading

Description

Add configuration for devSepolia. It will be a test deployment on sepolia testnet.

Task ID: OS-1444

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I created tasks to update dependent repositories (OSx, Plugins)
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.

@clauBv23 clauBv23 requested review from Rekard0 and novaknole and removed request for Rekard0 August 5, 2024 12:01
novaknole
novaknole reviewed Aug 5, 2024
View reviewed changes
Copy link
Contributor

@novaknole novaknole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, other than that, LGTM.

@clauBv23 clauBv23 requested a review from novaknole August 7, 2024 10:30
Rekard0
Rekard0 previously approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clauBv23 clauBv23 changed the base branch from main to develop August 7, 2024 14:28
@clauBv23 clauBv23 dismissed Rekard0’s stale review August 7, 2024 14:28

The base branch was changed.

@clauBv23 clauBv23 requested a review from Rekard0 August 7, 2024 14:29
@clauBv23 clauBv23 changed the base branch from develop to main August 7, 2024 14:29
@clauBv23 clauBv23 changed the base branch from main to develop August 7, 2024 14:29
@clauBv23 clauBv23 merged commit 0d84913 into develop Aug 7, 2024
5 checks passed
@clauBv23 clauBv23 deleted the feat/new-dev-sepolia-network-deployment branch August 7, 2024 21:03
@clauBv23 clauBv23 changed the title Feat/new dev sepolia network deployment feat: new dev sepolia network deployment Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rekard0 Rekard0 Rekard0 approved these changes

@novaknole novaknole novaknole approved these changes

Assignees
No one assigned
Labels
configs configs-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clauBv23 @Rekard0 @novaknole