Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: targets and standardized proposal #99

Open
wants to merge 25 commits into
base: develop
Choose a base branch
from
Open

feature: targets and standardized proposal #99

wants to merge 25 commits into from

Commits on Aug 14, 2024

  1. proposal and plugins interfaces changes with backwards compatibility

    @novaknole
    novaknole committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    27e6088 View commit details
    Browse the repository at this point in the history

  2. add artifacts folder in gitignore

    @novaknole
    novaknole committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    f6f5f3d View commit details
    Browse the repository at this point in the history

  3. fix calldata to memory

    @novaknole
    novaknole committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    b233838 View commit details
    Browse the repository at this point in the history

  4. add tests

    @novaknole
    novaknole committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    decd4ff View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. add operation type for target

    @novaknole
    novaknole committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    918763d View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. feat: add tests and refactor (#100) 

    * feat: add test for checking the ExecuteFailed is properly emitted

* feat: add new case in mock executor to simulate the tests

* feat: refactor code to avoid duplications

* ci: fix solhint warnings

* ci: fix lint issues
    @clauBv23
    clauBv23 authored Aug 22, 2024
    Configuration menu
    Copy the full SHA
    045a403 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. remove previous target from targetset event

    @novaknole
    novaknole committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    f4dc570 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. add get proposalid in the interface

    @novaknole
    novaknole committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    5306a73 View commit details
    Browse the repository at this point in the history

  2. rename function

    @novaknole
    novaknole committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    6def9f4 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. from calldata to memory

    @novaknole
    novaknole committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9b799db View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. improved target config and virtual functions

    @novaknole
    novaknole committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    23c73bd View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. add params byte approach (#102) 

    * add params byte approach

* add simple executor (#103)

* add simple executor

* action as free level export
    @novaknole
    novaknole authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    db446f5 View commit details
    Browse the repository at this point in the history

  2. executor added with reentrancy guard

    @novaknole
    novaknole committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    21ccec8 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. call initialization only

    @novaknole
    novaknole committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    d1feeeb View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. add comments

    @novaknole
    novaknole committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    55a0cc6 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. fallback to dao as a target if no target set (#104)

    @novaknole
    novaknole authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    2476aa2 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. metadata contracts (#105) 

    * metadata contracts

* rename

* diamond storage for metadata

* remove revert
    @novaknole
    novaknole authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    db06fde View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Update contracts/src/executors/IExecutor.sol 

    Co-authored-by: Jør∂¡ <[email protected]>
    @novaknole @brickpop
    novaknole and brickpop authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    409c90c View commit details
    Browse the repository at this point in the history

  2. review changes

    @novaknole
    novaknole committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    2f31a61 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature/targets-and-standardized-proposal' of https://g… 

    …ithub.com/aragon/osx-commons into feature/targets-and-standardized-proposal
    @novaknole
    novaknole committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    8916046 View commit details
    Browse the repository at this point in the history

  4. unused import remove

    @novaknole
    novaknole committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    cf6cdc5 View commit details
    Browse the repository at this point in the history

  5. remove unusued import

    @novaknole
    novaknole committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    2cc8ea5 View commit details
    Browse the repository at this point in the history

  6. from memory to calldata in metadataextension

    @novaknole
    novaknole committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    8a23aea View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. create proposal id not enforced (#106) 

    * create proposal id not enforced

* new changes
    @novaknole
    novaknole authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    ef42b24 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. remove unusued function

    @novaknole
    novaknole committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    2016e23 View commit details
    Browse the repository at this point in the history