CLI: Update protocol to v1.0.0-beta.3 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohkai
reviewed
Nov 10, 2020
There was a problem hiding this comment.
Couple small notes on the setup script, but otherwise:
- Should we rename the
settle-jurorcommand's file tosettle-guardian? - Do we need to update the
paymentcommand? - Does the
executescript still apply? - Did we have any commands for withdrawing from the treasury or pulling from the subscriptions modules that we need to update?
| // create disputes | ||
| for (let i = 0; i < disputes; i++) { | ||
| const arbitrable = arbitrables[i] | ||
| const output = execSync(`node ./bin/index.js arbitrable -n ${network}`) |
There was a problem hiding this comment.
Wasn't sure, but does this deploy a new ArbitrableMock? Why aren't we able to use the previous arbitrables[i]?
Looking at the old code, was this just broken code?
| const arbitrable = arbitrables[i] | ||
| const output = execSync(`node ./bin/index.js arbitrable -n ${network}`) | ||
| const arbitrable = output.toString().match(/0x[a-fA-F0-9]{40}/g) | ||
| console.log(arbitrable) |
There was a problem hiding this comment.
Maybe it's worth logging a bit more info here :)
| @@ -11,7 +11,7 @@ const logger = Logger('setup') | |||
| const { network, guardians: guardiansNumber, disputes } = yargs | |||
There was a problem hiding this comment.
I didn't find documentation on this script in the package's README, so wasn't sure when this was meant to be used. This is just for setting up an environment on the local chain?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.