Skip to content

Commit

Permalink
extracted logic to get the applyUpdateAction
Browse files Browse the repository at this point in the history
  • Loading branch information
@Fabricevladimir
Fabricevladimir committed Dec 5, 2023
1 parent b2be8af commit 6a7b22d
Showing 1 changed file with 19 additions and 50 deletions.
69 changes: 19 additions & 50 deletions modules/client/test/unit/client/utils.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,16 @@ describe("Test client utils", () => {
]);
});
});

describe("validateApplyUpdateFunction", () => {
function getApplyUpdateAction(daoAddress: string, applyUpdateParams: ApplyUpdateParams) {
const applyUpdateActions = client.encoding.applyUpdateAndPermissionsActionBlock(
daoAddress,
applyUpdateParams,
);
return applyUpdateActions[1];
}

beforeEach(() => {
mockedClient.request.mockReset();
mockedIPFSClient.cat.mockReset();
Expand Down Expand Up @@ -694,11 +703,7 @@ describe("Test client utils", () => {
};
});
it("should return an empty array for a valid action", async () => {
const applyUpdateActions = client.encoding.applyUpdateAndPermissionsActionBlock(
daoAddress,
applyUpdateParams,
);
const action = applyUpdateActions[1];
const action = getApplyUpdateAction(daoAddress, applyUpdateParams);
mockedClient.request.mockResolvedValue({
dao: subgraphDao,
pluginRepo: subgraphPluginRepo,
Expand All @@ -716,11 +721,7 @@ describe("Test client utils", () => {
expect(result).toEqual([]);
});
it("should return an `INVALID_APPLY_UPDATE_ACTION_VALUE` when the value in the action is not 0", async () => {
const applyUpdateActions = client.encoding.applyUpdateAndPermissionsActionBlock(
daoAddress,
applyUpdateParams,
);
const action = applyUpdateActions[1];
const action = getApplyUpdateAction(daoAddress, applyUpdateParams);
action.value = BigInt(10);
mockedClient.request.mockResolvedValue({
dao: subgraphDao,
Expand Down Expand Up @@ -748,11 +749,7 @@ describe("Test client utils", () => {
build: 2,
},
};
const applyUpdateActions = client.encoding.applyUpdateAndPermissionsActionBlock(
daoAddress,
updatedApplyUpdateParams,
);
const action = applyUpdateActions[1];
const action = getApplyUpdateAction(daoAddress, updatedApplyUpdateParams);
mockedClient.request.mockResolvedValue({
pluginRepo: subgraphPluginRepo,
dao: subgraphDao,
Expand Down Expand Up @@ -780,11 +777,7 @@ describe("Test client utils", () => {
build: 1,
},
};
const applyUpdateActions = client.encoding.applyUpdateAndPermissionsActionBlock(
daoAddress,
updatedApplyUpdateParams,
);
const action = applyUpdateActions[1];
const action = getApplyUpdateAction(daoAddress, updatedApplyUpdateParams);
mockedClient.request.mockResolvedValue({
dao: subgraphDao,
pluginRepo: subgraphPluginRepo,
Expand All @@ -808,11 +801,7 @@ describe("Test client utils", () => {
...subgraphDao,
plugins: [],
};
const applyUpdateActions = client.encoding.applyUpdateAndPermissionsActionBlock(
daoAddress,
applyUpdateParams,
);
const action = applyUpdateActions[1];
const action = getApplyUpdateAction(daoAddress, applyUpdateParams);
mockedClient.request.mockResolvedValue({
dao: subgraphDaoWithoutPlugin,
});
Expand All @@ -831,11 +820,7 @@ describe("Test client utils", () => {
...subgraphPluginRepo,
subdomain: "external-plugin-repo",
};
const applyUpdateActions = client.encoding.applyUpdateAndPermissionsActionBlock(
daoAddress,
applyUpdateParams,
);
const action = applyUpdateActions[1];
const action = getApplyUpdateAction(daoAddress, applyUpdateParams);
mockedClient.request.mockResolvedValue({
dao: subgraphDao,
pluginRepo: externalPluginRepo,
Expand All @@ -855,11 +840,7 @@ describe("Test client utils", () => {
]);
});
it("should return an `MISSING_PLUGIN_REPO` when the plugin repo is not on subgraph", async () => {
const applyUpdateActions = client.encoding.applyUpdateAndPermissionsActionBlock(
daoAddress,
applyUpdateParams,
);
const action = applyUpdateActions[1];
const action = getApplyUpdateAction(daoAddress, applyUpdateParams);
mockedClient.request.mockResolvedValue({
dao: subgraphDao,
pluginRepo: null,
Expand All @@ -879,11 +860,7 @@ describe("Test client utils", () => {
...applyUpdateParams,
initData: new Uint8Array([1, 2, 3]),
};
const applyUpdateActions = client.encoding.applyUpdateAndPermissionsActionBlock(
daoAddress,
updatedApplyUpdateParams,
);
const action = applyUpdateActions[1];
const action = getApplyUpdateAction(daoAddress, updatedApplyUpdateParams);
mockedClient.request.mockResolvedValue({
dao: subgraphDao,
pluginPreparations: [subgraphPluginPreparation],
Expand All @@ -903,11 +880,7 @@ describe("Test client utils", () => {
]);
});
it("should return an `INVALID_PLUGIN_REPO_METADATA` when the provided metadata does not exist or is not correct", async () => {
const applyUpdateActions = client.encoding.applyUpdateAndPermissionsActionBlock(
daoAddress,
applyUpdateParams,
);
const action = applyUpdateActions[1];
const action = getApplyUpdateAction(daoAddress, applyUpdateParams);
mockedClient.request.mockResolvedValue({
dao: subgraphDao,
pluginRepo: subgraphPluginRepo,
Expand All @@ -927,11 +900,7 @@ describe("Test client utils", () => {
]);
});
it("should return an `MISSING_PLUGIN_PREPARATION` when the pluginPreparation is null", async () => {
const applyUpdateActions = client.encoding.applyUpdateAndPermissionsActionBlock(
daoAddress,
applyUpdateParams,
);
const action = applyUpdateActions[1];
const action = getApplyUpdateAction(daoAddress, applyUpdateParams);
mockedClient.request.mockResolvedValue({
dao: subgraphDao,
pluginPreparations: [],
Expand Down

0 comments on commit 6a7b22d

Please sign in to comment.