Feature: Add admin governance plugin client #124
Conversation
modules/client/examples.md
Outdated
| const context = new Context(contextParams); | ||
| const contextPlugin: ContextPlugin = ContextPlugin.fromContext(context); | ||
|
|
||
| const client = new ClientAdmin(contextPlugin); |
There was a problem hiding this comment.
ClientAdmin or AdminClient? Probably the current is consistent with the rest but I see the upcoming MultisigClient, OvoteClient, TokenVotingClient... making more sense :-/
There was a problem hiding this comment.
Okay, we can change it here and make a task to change it everywhere
modules/client/examples.md
Outdated
| const queryParams: IProposalQueryParams = { | ||
| skip: 0, // optional | ||
| limit: 10, // optional, |
There was a problem hiding this comment.
Didn't we say that subgraph doesn't allow pagination?
There was a problem hiding this comment.
Well this is not a pagination, we cannot specify a page because we can't have the total amount of entries of a particular object, for example proposals. We can add a variable to count the number of proposals, the problem that we cannot have the total amount of proposals in a specific state, because the states mainly depend on the current time so from subgraph we cannot detect when a proposal passes from a pending state to a active state or when it passes from an active state to succeded or defeated, because this changes depend on the startDate and endDate of the proposal, and there is no way of tracking that in subgraph.
This was what the UI requested and what the task that we closed was about
modules/client/examples.md
Outdated
| /* | ||
| [ | ||
| { | ||
| id: "0x12345...", |
There was a problem hiding this comment.
This is inconsistent with the proposal ID's used elsewhere, now bigints
There was a problem hiding this comment.
I know, but the subgraph is using pluginAdddress_proposalId as id because it has to be unique, the bigint proposal ID is in the field proposalId
| }; | ||
|
|
||
| type ProposalBase = { | ||
| id: string; |
There was a problem hiding this comment.
id? or proposal id below?
There was a problem hiding this comment.
id = pluginAddress_proposalId, has to be unique on subgraph
| plugin: { | ||
| address: string; | ||
| }; | ||
| proposalId: string; |
| const metadataString = await this.ipfs.fetchString(metadataCid); | ||
| const metadata = JSON.parse(metadataString) as ProposalMetadata; | ||
| return toAdminProposal(adminProposal, metadata); | ||
| // TODO: Parse and validate schema |
There was a problem hiding this comment.
Do we need a follow up task?
There was a problem hiding this comment.
If we merge this one first I'll add the validation on the validation branch, if we merge the validation branch first i'll add it on this branch
josemarinas
force-pushed
the
f/APP-922-admin-governance-plugin
branch
from
e90bfd7
to
0480d67
Compare
josemarinas
force-pushed
the
f/APP-922-admin-governance-plugin
branch
from
0480d67
to
f031958
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Description
Create a client for the admin governance plugin
Task: APP-1315
Type of change
Checklist:
CHANGELOG.mdfile in the root folder of the package after the [UPCOMING] title and before the latest version.