Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add support or plugins prepared but not applied #255

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented Jul 19, 2023

Description

At the moment the sdk would crash when a plugin is prepared but not installed, for simplicity matters the dao only shows the fully installed plugins, this PR aims to filter the ones coming from subgraph that are prepared but not applied so it does not crash

Task ID: OS-542

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them when possible.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

Rekard0
Rekard0 previously approved these changes Jul 21, 2023
@josemarinas josemarinas force-pushed the f/OS-542-support-prepare-but-not-applied-plugins branch from 3cb6c8e to b4dfea6 Compare July 21, 2023 13:07
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@josemarinas josemarinas merged commit 51ba5b6 into develop Jul 21, 2023
7 checks passed
@josemarinas josemarinas deleted the f/OS-542-support-prepare-but-not-applied-plugins branch July 21, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants