Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Fix default params #256

Merged
merged 3 commits into from
Jul 22, 2023
Merged

Feature: Fix default params #256

merged 3 commits into from
Jul 22, 2023

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented Jul 20, 2023 •
edited by jira bot
Loading

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task ID: OS-597

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them when possible.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

@josemarinas josemarinas added client-common-release Releases a new version of the client-common package client-release Publishes the current version of client subpackage on NPM labels Jul 20, 2023
juliettech13
juliettech13 previously approved these changes Jul 20, 2023
View reviewed changes
Rekard0
Rekard0 previously approved these changes Jul 21, 2023
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Jul 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@josemarinas josemarinas merged commit 5c3d30f into develop Jul 22, 2023
7 checks passed
@josemarinas josemarinas deleted the f/OS-597-fix-default-params branch July 22, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fabricevladimir Fabricevladimir Fabricevladimir approved these changes

@Rekard0 Rekard0 Rekard0 left review comments

@brickpop brickpop Awaiting requested review from brickpop

@juliettech13 juliettech13 Awaiting requested review from juliettech13

Assignees
No one assigned
Labels
client-common-release Releases a new version of the client-common package client-release Publishes the current version of client subpackage on NPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josemarinas @Rekard0 @Fabricevladimir @juliettech13