Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the network mandatory on get plugin install item #260

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Make the network mandatory on get plugin install item #260

merged 4 commits into from
Jul 24, 2023

Conversation

brickpop
Copy link
Contributor

@brickpop brickpop commented Jul 24, 2023 •
edited by jira bot
Loading

Description

The current implementation leads developers to confusion when the network parameter is omitted on getPluginInstallItem

Task ID: OS-610

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them when possible.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

josemarinas
josemarinas previously approved these changes Jul 24, 2023
View reviewed changes
@josemarinas josemarinas force-pushed the fix/OS-610-get-plugin-install-item branch from 26364ee to ce7a582 Compare July 24, 2023 11:19
@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.9% 7.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@brickpop brickpop merged commit 5aa74dc into develop Jul 24, 2023
6 of 7 checks passed
@brickpop brickpop deleted the fix/OS-610-get-plugin-install-item branch July 24, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josemarinas josemarinas josemarinas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brickpop @josemarinas