Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add support for base-goerli #263

Merged
merged 6 commits into from
Jul 31, 2023
Merged

Feature: Add support for base-goerli #263

merged 6 commits into from
Jul 31, 2023

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented Jul 27, 2023 •
edited by jira bot
Loading

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task ID: OS-620
Task ID: OS-621
Task ID: OS-628

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them when possible.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

heueristik
heueristik reviewed Jul 27, 2023
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
heueristik
heueristik reviewed Jul 27, 2023
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Two questions regarding tests and versioning.

@josemarinas josemarinas force-pushed the f/OS-619-support-for-base-goerli branch from 70e1a26 to 17d8bff Compare July 28, 2023 08:19
mathewmeconry
mathewmeconry previously approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@mathewmeconry mathewmeconry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

heueristik
heueristik previously approved these changes Jul 28, 2023
View reviewed changes
@josemarinas josemarinas force-pushed the f/OS-619-support-for-base-goerli branch from b01542c to 89562ad Compare July 31, 2023 13:14
@josemarinas josemarinas added client-release Publishes the current version of client subpackage on NPM client-common-release Releases a new version of the client-common package labels Jul 31, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.6% 8.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@josemarinas josemarinas merged commit edf2588 into develop Jul 31, 2023
6 of 7 checks passed
@josemarinas josemarinas deleted the f/OS-619-support-for-base-goerli branch July 31, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heueristik heueristik heueristik approved these changes

@mathewmeconry mathewmeconry mathewmeconry left review comments

@brickpop brickpop Awaiting requested review from brickpop

Assignees
No one assigned
Labels
client-common-release Releases a new version of the client-common package client-release Publishes the current version of client subpackage on NPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josemarinas @mathewmeconry @heueristik